From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Wahl <marcowahlsoft@gmail.com>
Subject: Re: [PATCH] Kill in eww and keep the links for org
Date: Tue, 07 Oct 2014 16:16:38 +0200
Message-ID: <84h9zgoth5.fsf@tm6592.fritz.box>
References: <84fvf01961.fsf@tm6592.fritz.box>
	<87wq8c2mcz.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1XbVZX-00065h-3N
	for emacs-orgmode@gnu.org; Tue, 07 Oct 2014 10:17:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1XbVZQ-000245-GC
	for emacs-orgmode@gnu.org; Tue, 07 Oct 2014 10:17:03 -0400
Received: from plane.gmane.org ([80.91.229.3]:38142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1XbVZQ-00023v-AX
	for emacs-orgmode@gnu.org; Tue, 07 Oct 2014 10:16:56 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1XbVZJ-0007Yj-S6
	for emacs-orgmode@gnu.org; Tue, 07 Oct 2014 16:16:49 +0200
Received: from stgt-4d02d400.pool.mediaways.net ([77.2.212.0])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Tue, 07 Oct 2014 16:16:49 +0200
Received: from marcowahlsoft by stgt-4d02d400.pool.mediaways.net with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Tue, 07 Oct 2014 16:16:49 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hi!

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Since the file is in contrib and you're its author, you can obviously
> push the code.

Thanks for making that clear.

> Some minor comments follow.
>
>> +;;; org-eww.el --- Store url and kill from eww-mode for Org
>
> Eww mode
>
>> +    (equal (point) (org-eww-goto-next-url-property-change))))
>
>   (eq (point) (org-eww-goto-next-url-property-change))
>
>> +  (not (eq nil (org-eww-url-below-point))))
>
>   (org-eww-url-below-point)
>
> or, if you insist on returning t,
>
>   (and (org-eww-url-below-point) t)

I insist ;)

Thanks for your hints.  Applied and pushed.


Best regards,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2