emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Kill in eww and keep the links for org
Date: Tue, 07 Oct 2014 16:16:38 +0200	[thread overview]
Message-ID: <84h9zgoth5.fsf@tm6592.fritz.box> (raw)
In-Reply-To: 87wq8c2mcz.fsf@nicolasgoaziou.fr

Hi!

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Since the file is in contrib and you're its author, you can obviously
> push the code.

Thanks for making that clear.

> Some minor comments follow.
>
>> +;;; org-eww.el --- Store url and kill from eww-mode for Org
>
> Eww mode
>
>> +    (equal (point) (org-eww-goto-next-url-property-change))))
>
>   (eq (point) (org-eww-goto-next-url-property-change))
>
>> +  (not (eq nil (org-eww-url-below-point))))
>
>   (org-eww-url-below-point)
>
> or, if you insist on returning t,
>
>   (and (org-eww-url-below-point) t)

I insist ;)

Thanks for your hints.  Applied and pushed.


Best regards,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2

      reply	other threads:[~2014-10-07 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 10:11 [PATCH] Kill in eww and keep the links for org Marco Wahl
2014-10-07 10:41 ` Nicolas Goaziou
2014-10-07 14:16   ` Marco Wahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84h9zgoth5.fsf@tm6592.fritz.box \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).