From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Wahl <marcowahlsoft@gmail.com>
Subject: Re: Bug in Recent Agenda Mod
Date: Tue, 21 Mar 2017 21:13:36 +0100
Message-ID: <847f3iqtfz.fsf@tm6592>
References: <87efxrv5s5.fsf@escafil> <841strys2e.fsf@tm6592>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cqQAF-0004VK-9z
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 16:13:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cqQAC-0007iJ-2t
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 16:13:55 -0400
Received: from [195.159.176.226] (port=41434 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>)
	id 1cqQAB-0007hs-RJ
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 16:13:52 -0400
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cqQ9z-0004C6-I3
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 21:13:39 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Marco Wahl <marcowahlsoft@gmail.com> writes:

> Ian Dunn <dunni@gnu.org> writes:
>
>> Commit d262ae53c966c7a745c0fa779149f9eb7486333d "org-agenda: Fix agenda standard name when going unsticky" sets org-agenda-buffer-name to "*Org Agenda*" if not in sticky.
>>
>> However, org-agenda-redo sets org-agenda-sticky to nil before redoing the agenda command.
>>
>> Steps to Reproduce:
>>
>> 1. Turn on org-agenda-sticky
>> 2. Execute any agenda command that only involves org-agenda-list
>>    - Agenda is in buffer *Org Agenda(CMD)* (ex. *Org Agenda(d:)*)
>> 3. Press 'g' (org-agenda-redo)
>>    - Agenda is now in *Org Agenda*
>>
>> The included patch fixes this for sticky redo, and will have no effect for anything other than a sticky redo.
>>
>> --
>> Ian Dunn
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index b618653d5..04e6685b5 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -4076,6 +4076,7 @@ items if they have an hour specification like [h]h:mm."
>>    (catch 'exit
>>      (setq org-agenda-buffer-name
>>  	  (or org-agenda-buffer-tmp-name
>> +	      (and org-agenda-doing-sticky-redo org-agenda-buffer-name)
>>  	      (if org-agenda-sticky
>>  		  (cond ((and org-keys (stringp org-match))
>>  			 (format "*Org Agenda(%s:%s)*" org-keys org-match))
>
> Good catch, good fix AFAICT.  Thanks.
>
> May I add this line with a commit message referencing you as the
> originator?  (I have not found you in the contributors list.)

I just committed your fix.


Ciao