emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* patch to add mention of org-table-transpose-table-at-point to doc
@ 2020-11-17 14:53 Greg Minshall
  2020-11-19  4:16 ` Kyle Meyer
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Minshall @ 2020-11-17 14:53 UTC (permalink / raw)
  Cc: Org-mode

hi.  this adds the minimal mention of transpose.  cheers.


diff --git a/doc/org-manual.org b/doc/org-manual.org
index 040fccc21..33d32b8f5 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -1649,6 +1649,12 @@ you, configure the option ~org-table-auto-blank-field~.
   the buffer.  You can activate this minor mode by default by setting
   the option ~org-table-header-line-p~ to ~t~.
 
+- {{{kbd(M-x org-table-transpose-table-at-point)}}} ::
+
+  #+findex: org-table-header-line-mode
+  #+vindex: org-table-header-line-p
+  Transpose the table at point and eliminate hlines.
+
 ** Column Width and Alignment
 :PROPERTIES:
 :DESCRIPTION: Overrule the automatic settings.


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: patch to add mention of org-table-transpose-table-at-point to doc
  2020-11-17 14:53 patch to add mention of org-table-transpose-table-at-point to doc Greg Minshall
@ 2020-11-19  4:16 ` Kyle Meyer
  2020-11-19  8:11   ` [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point Greg Minshall
  0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2020-11-19  4:16 UTC (permalink / raw)
  To: Greg Minshall; +Cc: Org-mode

Greg Minshall writes:

> hi.  this adds the minimal mention of transpose.  cheers.

Thanks.  Could you add a commit message to the patch (using
git-format-patch)?

> diff --git a/doc/org-manual.org b/doc/org-manual.org
> index 040fccc21..33d32b8f5 100644
> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -1649,6 +1649,12 @@ you, configure the option ~org-table-auto-blank-field~.
>    the buffer.  You can activate this minor mode by default by setting
>    the option ~org-table-header-line-p~ to ~t~.
>  
> +- {{{kbd(M-x org-table-transpose-table-at-point)}}} ::
> +
> +  #+findex: org-table-header-line-mode
> +  #+vindex: org-table-header-line-p

It looks like the last two lines are leftover from pasting the previous
entry.  s/header-line-mode/transpose-table-at-point/ and drop the
org-table-header-line-p line?

> +  Transpose the table at point and eliminate hlines.
> +


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point
  2020-11-19  4:16 ` Kyle Meyer
@ 2020-11-19  8:11   ` Greg Minshall
  2020-11-20  4:11     ` Kyle Meyer
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Minshall @ 2020-11-19  8:11 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Org-mode

Kyle, thanks.  yes, blind copy and paste.  i'm not a git-format-patch
expert, so let me know if this is the wrong format (i see some people
include inline, whereas others attach a file -- is one easier to handle
than the other?)

---
 doc/org-manual.org | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 040fccc21..953ab6bd3 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -1649,6 +1649,11 @@ you, configure the option ~org-table-auto-blank-field~.
   the buffer.  You can activate this minor mode by default by setting
   the option ~org-table-header-line-p~ to ~t~.

+- {{{kbd(M-x org-table-transpose-table-at-point)}}} ::
+
+  #+findex: org-table-transpose-table-at-point
+  Transpose the table at point and eliminate hlines.
+
 ** Column Width and Alignment
 :PROPERTIES:
 :DESCRIPTION: Overrule the automatic settings.
--
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point
  2020-11-19  8:11   ` [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point Greg Minshall
@ 2020-11-20  4:11     ` Kyle Meyer
  2020-11-20 11:44       ` Greg Minshall
  0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2020-11-20  4:11 UTC (permalink / raw)
  To: Greg Minshall; +Cc: Org-mode

Greg Minshall writes:

> Kyle, thanks.  yes, blind copy and paste.  i'm not a git-format-patch
> expert, so let me know if this is the wrong format (i see some people
> include inline, whereas others attach a file -- is one easier to handle
> than the other?)

Either way is fine on this list, and, while I can of course only speak
for myself, I don't find one harder to handle than the other,
particularly for one-patch series.  It comes down to whichever is
easiest for the sender.

With a single inline patch like yours, the placement of the text that
isn't meant for the commit message needs some special consideration.  If
your message is fed to 'git am', the quoted text above would go into the
commit message, so the person applying would need to amend it to clean
it up.

There are two options to deal with this extra text: 1) place it under
the "---" at the end of the commit message or 2) add a "-- >8 --"
between the extra text and the main commit message text, which can be
automatically stripped out by passing -c to 'git am'.  The first option
works well for things like extra notes but reads a bit awkward for text
that would more naturally lead the message.

Below is an example of the second method.  The From header is only
needed to override my From header from the actual mail.  I've added a
changelog entry.

Pushed as a5d765481.  Thanks!

-- >8 --
From: Greg Minshall <minshall@umich.edu>

* doc/org-manual.org (Built-in Table Editor): Add
org-table-transpose-table-at-point to list of miscellaneous commands.
---
 doc/org-manual.org | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 0a3a8c6cd..34b0164fc 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -1649,6 +1649,11 @@ *** Miscellaneous
   the buffer.  You can activate this minor mode by default by setting
   the option ~org-table-header-line-p~ to ~t~.
 
+- {{{kbd(M-x org-table-transpose-table-at-point)}}} ::
+
+  #+findex: org-table-transpose-table-at-point
+  Transpose the table at point and eliminate hlines.
+
 ** Column Width and Alignment
 :PROPERTIES:
 :DESCRIPTION: Overrule the automatic settings.

base-commit: 104d92199e3cba7cefd504f24c3610031fa384de
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point
  2020-11-20  4:11     ` Kyle Meyer
@ 2020-11-20 11:44       ` Greg Minshall
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Minshall @ 2020-11-20 11:44 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Org-mode

Kyle, thanks.  i assume a patch e-mail with no explanatory message is
not considered rude, so i'll try to remember to do that (or "scissors"
-- thanks for that!).  and, thanks for pushing.  cheers!  Greg


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-20 11:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 14:53 patch to add mention of org-table-transpose-table-at-point to doc Greg Minshall
2020-11-19  4:16 ` Kyle Meyer
2020-11-19  8:11   ` [PATCH] doc/org-manual.org: add reference to org-table-transpose-table-at-point Greg Minshall
2020-11-20  4:11     ` Kyle Meyer
2020-11-20 11:44       ` Greg Minshall

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).