* bug#24073: 25.1-rc2 [not found] ` <83shtlkoba.fsf@gnu.org> @ 2016-09-03 4:38 ` Paul Rankin 2016-09-18 14:39 ` Eli Zaretskii 0 siblings, 1 reply; 4+ messages in thread From: Paul Rankin @ 2016-09-03 4:38 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 24073, emacs-orgmode Eli Zaretskii <eliz@gnu.org> on Wed, 31 Aug 2016 17:25 +0300: > > From: Paul Rankin <hello@paulwrankin.com> > > Date: Wed, 31 Aug 2016 12:56:13 +1000 > > Cc: 24073@debbugs.gnu.org > > > > >> The fix seems trivial to me so I'm wondering if there is anything holding it > > >> up from being included in 25? > > > > > > Yes, the fact that Emacs 25 is for all practical purposes already > > > released. > > > > Okay. 25.2? > > I don't see why not, provided that Org developers give us their > blessing. Please bring this to their attention on the Org list, or > ask them to speak up here. I don't want us to make any changes that > could adversely affect Org without consulting them first. Dear Org Mode maintainers, Looping you in on a proposed bug fix for `outline-invisible-p'. Briefly, the problem is the function returns non-nil for any invisible text property when it should only do so for the outline property. As a defsubst, it is difficult to patch for other affected programs. Diff pasted: --- /usr/local/Cellar/emacs/25.1-rc2/share/emacs/25.1/lisp/outline.el.gz +++ #<buffer outline.el.gz> @@ -388,9 +388,9 @@ nil 'move)) (defsubst outline-invisible-p (&optional pos) - "Non-nil if the character after POS is invisible. + "Non-nil if the character after POS has outline invisible property. If POS is nil, use `point' instead." - (get-char-property (or pos (point)) 'invisible)) + (eq (get-char-property (or pos (point)) 'invisible) 'outline)) (defun outline-back-to-heading (&optional invisible-ok) "Move to previous heading line, or beg of this line if it's a heading. Diff finished. Sat Sep 3 14:35:22 2016 ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#24073: 25.1-rc2 2016-09-03 4:38 ` bug#24073: 25.1-rc2 Paul Rankin @ 2016-09-18 14:39 ` Eli Zaretskii 2016-09-18 14:45 ` Nicolas Goaziou 0 siblings, 1 reply; 4+ messages in thread From: Eli Zaretskii @ 2016-09-18 14:39 UTC (permalink / raw) To: Paul Rankin, Bastien Guerry; +Cc: 24073, emacs-orgmode Ping! Bastien, could you or someone else please look into this and provide your comments? TIA. > From: Paul Rankin <hello@paulwrankin.com> > Cc: 24073@debbugs.gnu.org, emacs-orgmode@gnu.org > Date: Sat, 03 Sep 2016 14:38:55 +1000 > > Eli Zaretskii <eliz@gnu.org> on Wed, 31 Aug 2016 17:25 +0300: > > > From: Paul Rankin <hello@paulwrankin.com> > > > Date: Wed, 31 Aug 2016 12:56:13 +1000 > > > Cc: 24073@debbugs.gnu.org > > > > > > >> The fix seems trivial to me so I'm wondering if there is anything holding it > > > >> up from being included in 25? > > > > > > > > Yes, the fact that Emacs 25 is for all practical purposes already > > > > released. > > > > > > Okay. 25.2? > > > > I don't see why not, provided that Org developers give us their > > blessing. Please bring this to their attention on the Org list, or > > ask them to speak up here. I don't want us to make any changes that > > could adversely affect Org without consulting them first. > > Dear Org Mode maintainers, > > Looping you in on a proposed bug fix for `outline-invisible-p'. > > Briefly, the problem is the function returns non-nil for any invisible > text property when it should only do so for the outline property. As a > defsubst, it is difficult to patch for other affected programs. > > Diff pasted: > > --- /usr/local/Cellar/emacs/25.1-rc2/share/emacs/25.1/lisp/outline.el.gz > +++ #<buffer outline.el.gz> > @@ -388,9 +388,9 @@ > nil 'move)) > > (defsubst outline-invisible-p (&optional pos) > - "Non-nil if the character after POS is invisible. > + "Non-nil if the character after POS has outline invisible property. > If POS is nil, use `point' instead." > - (get-char-property (or pos (point)) 'invisible)) > + (eq (get-char-property (or pos (point)) 'invisible) 'outline)) > > (defun outline-back-to-heading (&optional invisible-ok) > "Move to previous heading line, or beg of this line if it's a heading. > > Diff finished. Sat Sep 3 14:35:22 2016 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#24073: 25.1-rc2 2016-09-18 14:39 ` Eli Zaretskii @ 2016-09-18 14:45 ` Nicolas Goaziou 2016-09-18 15:34 ` Bastien Guerry 0 siblings, 1 reply; 4+ messages in thread From: Nicolas Goaziou @ 2016-09-18 14:45 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Bastien Guerry, Paul Rankin, 24073, emacs-orgmode Hello, Eli Zaretskii <eliz@gnu.org> writes: > Bastien, could you or someone else please look into this and provide > your comments? TIA. This fix looks fine, obviously. You can go ahead as far as Org is concerned. Thank you for letting us know. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug#24073: 25.1-rc2 2016-09-18 14:45 ` Nicolas Goaziou @ 2016-09-18 15:34 ` Bastien Guerry 0 siblings, 0 replies; 4+ messages in thread From: Bastien Guerry @ 2016-09-18 15:34 UTC (permalink / raw) To: Nicolas Goaziou; +Cc: Eli Zaretskii, 24073, emacs-orgmode, Paul Rankin Nicolas Goaziou <mail@nicolasgoaziou.fr> writes: > This fix looks fine, obviously. You can go ahead as far as Org is > concerned. +1 -- Bastien ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-18 15:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1469520753.418402.676896009.00AAC0DE@webmail.messagingengine.com>
[not found] ` <1472605956.265564.710992545.0AE0C6FD@webmail.messagingengine.com>
[not found] ` <83zintlkxl.fsf@gnu.org>
[not found] ` <0085D3FE-32C4-4AFB-89DA-9DD205D8A2AB@paulwrankin.com>
[not found] ` <83shtlkoba.fsf@gnu.org>
2016-09-03 4:38 ` bug#24073: 25.1-rc2 Paul Rankin
2016-09-18 14:39 ` Eli Zaretskii
2016-09-18 14:45 ` Nicolas Goaziou
2016-09-18 15:34 ` Bastien Guerry
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).