From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mK9gDMrWjmCLMwEAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 18:43:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kdwYCMrWjmATIwAA1q6Kng (envelope-from ) for ; Sun, 02 May 2021 16:43:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F41027C0F for ; Sun, 2 May 2021 18:43:53 +0200 (CEST) Received: from localhost ([::1]:56568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldFCC-0008As-9x for larch@yhetil.org; Sun, 02 May 2021 12:43:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldEt0-0004v2-5l; Sun, 02 May 2021 12:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldEsz-0001LU-RI; Sun, 02 May 2021 12:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldEsz-0004bF-N6; Sun, 02 May 2021 12:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#48149: 27.2; Wrong underline width when the line char has a width of 2 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 16:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48149 X-GNU-PR-Package: org-mode,emacs X-GNU-PR-Keywords: To: Nicolas Goaziou Received: via spool by 48149-submit@debbugs.gnu.org id=B48149.161997261117674 (code B ref 48149); Sun, 02 May 2021 16:24:01 +0000 Received: (at 48149) by debbugs.gnu.org; 2 May 2021 16:23:31 +0000 Received: from localhost ([127.0.0.1]:43569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldEsU-0004b0-Lg for submit@debbugs.gnu.org; Sun, 02 May 2021 12:23:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldEsT-0004au-1f for 48149@debbugs.gnu.org; Sun, 02 May 2021 12:23:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34343) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldEsN-0001Dh-D2; Sun, 02 May 2021 12:23:23 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4573 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldEsM-0003fo-GU; Sun, 02 May 2021 12:23:22 -0400 Date: Sun, 02 May 2021 19:23:02 +0300 Message-Id: <83im416r6h.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87a6pd86el.fsf@nicolasgoaziou.fr> (message from Nicolas Goaziou on Sun, 02 May 2021 18:08:50 +0200) References: <87fsz62b1w.wl-shingo.fg8@gmail.com> <87a6pd86el.fsf@nicolasgoaziou.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: emacs-orgmode@gnu.org List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shingo.fg8@gmail.com, 48149@debbugs.gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619973833; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=I5S4P4X7lQrYTT4sOUI96IyyHHjmE4/HxisEoyXaNug=; b=I0QeyEYNDRmbKQuJdDJZXJsuObW0B3wlWWIIKmgL+ba0l6GqRZf7LzVOrK6Nk+cDf4EZd7 BdifcbZHgGWELupsbCFDHrJiqL39y2ru/GcMUnO7+STXjrji76n2bSLRanUyNhroWtsZcA uvJB0OSqOs78btvCiCy4GF+Y8dD/iWgzJWEBlptTEr+4scOkKD0Lovf/BDaidVShvJm92S +XnxrT9QPztIOfDg36WJE95aW4t1kIazLFQhgpyn+qSJiH1YsfrixyXkHLCDZrKgSbxUVq SaRplMvAFxl6fu+YrPIUPH2Rt6/U/YSw8EnvAdvViULW+gcYkQyICRHhE5wC4g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619973833; a=rsa-sha256; cv=none; b=Supu1m7zMAXGlAC8HEiaC3jPsuSBub9Pd8iHbeYyxAi/fimQQ8ixgfm0F1PZ/W6hJgScLC 92nlM514HY3vEfVnTrqsuQ+AJEdM9h/ZFB+iUTevnyDIqJICeAlWXHsPFp3Lm1ltw8yLO/ 6z97cmpQd8d+nfPxiTgf6kIlL0T/hQKzgn+asvuAhR4A9BTKzUqwfcsLfCUNbIc6BIDj/3 c7tzJLmoGxDcr/fQXiZPyW4gcorL16Tc1C4jqSe4zDeVQ33ZVDaKcglY7/o6X9tsKpFYfb XisgI/UODrJ3Cokdc1fodKzE8KcE8bHy7rTeUgF3wzQcSWAQ1CihqGroo2vMZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 5F41027C0F X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: GxcGJUtAU1BT > From: Nicolas Goaziou > Date: Sun, 02 May 2021 18:08:50 +0200 > Cc: 48149@debbugs.gnu.org > > > In case of 1), it correctly takes account of the case in which the character > > has a width of 2 in `org-ascii--build-title', by dividing the line width by > > `(char-width under-char)' (line 700-701), maybe because the character is user > > configurable and its width in unknown. However, in case of 2) and > > 3), maybe because the characters is embedded in the code, it looks like only > > considering the character always has a width of 1. But the reality is > > character ?─ or ?━ can have a width of 2 in the screen displayed with some > > fonts (ex. "Noto Sans Mono CJK JP"), and in that case the line width gets > > doubled of the expected width. > > > > Attached one is a potential patch. The basic concepts are: > > > > a) Do the same in case of 2) and 3) as in case of 1) > > (dividing the line width by `(char-width under-char)', > > assuming `char-width-table' is correctly set) > > > > b) Prefer the longer line width if the width is odd, even in case of 1) > > (adding `(1- (char-width under-char))' to dividend, > > just because it should be more beautiful ;-) ) > > Thank you. This looks good. I cannot apply it on "maint" branch, > however. Also, a proper commit message would be nice. Could you send an > updated patch? Please note that using char-width cannot solve the problem of a character whose width depends on the font, because char-width is oblivious to fonts, it only knows about the character's codepoint.