From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros Date: Wed, 24 Jun 2009 14:17:59 +0200 Message-ID: <8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com> References: <87bponi011.fsf@gate450.dyndns.org> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJRQr-0003TM-1v for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:18:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJRQm-0003Jd-CD for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:18:28 -0400 Received: from [199.232.76.173] (port=41628 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJRQm-0003JP-1s for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:18:24 -0400 In-Reply-To: <87bponi011.fsf@gate450.dyndns.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Andreas Seltenreich Cc: emacs-pretest-bug@gnu.org, emacs-orgmode@gnu.org This looks to me as if it was a bug in keyboard macro execution, which should call functions interactively. - Carsten On Jun 17, 2009, at 1:15 PM, Andreas Seltenreich wrote: >> Your bug report will be posted to the emacs-pretest-bug@gnu.org >> mailing list. > >> Please describe exactly what actions triggered the bug >> and the precise symptoms of the bug: > > org-store-link works fine when recording a keyboard macro but it is a > NOP when executing it. The following change appears to fix it. > > regards, > andreas > >> In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu) >> of 2009-05-28 on tengen > > --8<---------------cut here---------------start------------->8--- > *** org.el.~1.48.~ 2009-02-20 10:02:49.000000000 +0100 > --- org.el 2009-06-17 12:55:15.000000000 +0200 > *************** > *** 6594,6600 **** > desc (or desc cpltxt)) > (if (equal desc "NONE") (setq desc nil)) > > ! (if (and (interactive-p) link) > (progn > (setq org-stored-links > (cons (list link desc) org-stored-links)) > --- 6594,6600 ---- > desc (or desc cpltxt)) > (if (equal desc "NONE") (setq desc nil)) > > ! (if (and (or (interactive-p) executing-kbd-macro) link) > (progn > (setq org-stored-links > (cons (list link desc) org-stored-links)) > --8<---------------cut here---------------end--------------->8--- > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode