From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jambunathan K <kjambunathan@gmail.com>
Subject: Re: [PATCH] org-babel-exp-lob-one-liners should not parse the entire
 buffer.
Date: Thu, 24 Nov 2011 23:58:40 +0530
Message-ID: <81pqgh4bon.fsf@gmail.com>
References: <ysmzkflh5us.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:41234)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kjambunathan@gmail.com>) id 1RTe2i-0002FJ-Qr
	for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 13:29:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kjambunathan@gmail.com>) id 1RTe2h-00065r-S9
	for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 13:29:04 -0500
Received: from mail-iy0-f169.google.com ([209.85.210.169]:55003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kjambunathan@gmail.com>) id 1RTe2h-00065k-Mf
	for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 13:29:03 -0500
Received: by iaek3 with SMTP id k3so4475922iae.0
	for <emacs-orgmode@gnu.org>; Thu, 24 Nov 2011 10:29:03 -0800 (PST)
In-Reply-To: <ysmzkflh5us.fsf@gmail.com> (=?utf-8?B?IkrDqXLDqW15?=
	Compostella"'s message of "Thu, 24 Nov 2011 16:56:11 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?utf-8?B?SsOpcsOpbXk=?= Compostella <jeremy.compostella@gmail.com>
Cc: emacs-orgmode@gnu.org


> All,
>
> I'm currently generating a road book for a trip from different Org-Mode
> file and other data. It results in a 13 thousands lines Org-Mode file
> and I have some performance issues. Using the ELP package, I isolated
> the two main bottlenecks.
>
> 1. One is in org-odt : the org-odt-write-manifest-file function is
>    called once and takes 5.546672 seconds to write a 167 lines file. I
>    rewrote this function and now it takes 0.01606 seconds to write the
>    same file. As usually for this package, I directly send the patch to
>    the org-odt author.

I think it is multiple write-region that takes the toll. I have pushed a
variation of your original fix which minimizes the number of lines
originally modified by you.

I have acknowledged you as the author in the commit message (even though
I appear as the author)

> As usually for this package, I directly send the patch to the org-odt
> author.

Btw, you can post your patches to the list. I am a regular on this list.

Jambunathan K.
--