From: Jambunathan K <kjambunathan@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH 2/2] Fix broken CUSTOM_ID links
Date: Mon, 08 Nov 2010 19:09:34 +0530 [thread overview]
Message-ID: <81oca0rl2h.fsf_-_@gmail.com> (raw)
In-Reply-To: <43EFAC24-FD29-4565-AB08-0C6F2AF6CBA5@gmail.com> (Carsten Dominik's message of "Sat, 6 Nov 2010 15:36:42 -0400")
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Carsten
> On Nov 5, 2010, at 6:53 PM, Jambunathan K wrote:
>
>>
>> Note the 'H:1' in options line. Export this to HTML. Note that
>> CUSTOMID
>> link is broken. A snippet of relevant HTML section is attached
>> below.
>>
>> Change 'H:1' to 'H:3' note that there is no more brokenness.
>>
>> Possible root cause: When headlines are turned to list 'extra-targets'
>> are not identified correctly.
>
> That is correct - Org does not assign IDs or names to list items,
> so it has no place to link to. This could probably be fixed - anyone
> would
> like to fix this?
>
I am attaching a patch. Hope it does the right thing.
[-- Attachment #2: Input Org File --]
[-- Type: text/plain, Size: 1014 bytes --]
#+OPTIONS: H:1
* Links
** Targets
*** Fuzzy Target
One
Two
Three
Four
Five
*** Target with CUSTOMID
:PROPERTIES:
:CUSTOM_ID: aabbccddeeff
:END:
One
Two
Three
Four
Five
*** Dedicated Target
# <<Dedicated Target>>
One
Two
Three
Four
Five
*** <<<Radioed Target>>>
One
Two
Three
Four
Five
** References
*** References to Fuzzy Target
This is a link to [[Fuzzy Target]].
*** References to CUSTOMID links
This link to [[#aabbccddeeff][CUSTOMID Target]] is broken.
*** References to Dedicated Target
There is a link to nodesc [[Dedicated Target]] here. There is a link
to [[Dedicated%20Target][Jump to Dedicated Target]] here.
*** References to Radioed Links
This section has references to Radioed Target. One more reference
to Radioed Target.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: before-after.diff --]
[-- Type: text/x-patch, Size: 1134 bytes --]
--- before.html 2010-11-08 19:01:13.796875000 +0530
+++ after.html 2010-11-08 19:00:57.859375000 +0530
@@ -7,7 +7,7 @@
<title>tmp</title>
<meta http-equiv="Content-Type" content="text/html;charset=iso-8859-1"/>
<meta name="generator" content="Org-mode"/>
- <meta name="generated" content="2010-11-08 18:57:46 "/>
+ <meta name="generated" content="2010-11-08 18:56:05 "/>
<meta name="author" content="Jambunathan K"/>
<meta name="description" content=""/>
<meta name="keywords" content=""/>
@@ -101,7 +101,7 @@
</li>
</ul>
<ul>
- <li id="sec-1_1_2"><a name="sec-1_1_2" id="sec-1_1_2"></a>Target with CUSTOMID <br/>
+ <li id="aabbccddeeff"><a name="sec-1_1_2" id="sec-1_1_2"></a>Target with CUSTOMID <br/>
<p>
One
@@ -200,7 +200,7 @@
<p class="author"> Author: Jambunathan K
<a href="mailto:kjambunathan@gmail.com"><kjambunathan@gmail.com></a>
</p>
- <p class="date"> Date: 2010-11-08 18:57:46 </p>
+ <p class="date"> Date: 2010-11-08 18:56:05 </p>
<p class="creator">HTML generated by org-mode 7.3 in emacs 23</p>
</div>
</div>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: patch --]
[-- Type: text/x-patch, Size: 1218 bytes --]
From 896a97a00c28206a940bb935406c60f19db3de15 Mon Sep 17 00:00:00 2001
From: Jambunathan K <kjambunathan@gmail.com>
Date: Mon, 8 Nov 2010 18:33:29 +0530
Subject: [PATCH 2/2] Fix broken CUSTOM_ID links to outline levels exported as lists.
(org-html-level-start): Modified.
TINYCHANGE.
---
lisp/org-html.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
mode change 100644 => 100755 lisp/org-html.el
diff --git a/lisp/org-html.el b/lisp/org-html.el
old mode 100644
new mode 100755
index 68fee5b..2aea978
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -2358,12 +2358,12 @@ When TITLE is nil, just close all open levels."
(progn
(org-close-li)
(if target
- (insert (format "<li id=\"%s\">" target) extra-targets title "<br/>\n")
+ (insert (format "<li id=\"%s\">" remove) extra-targets title "<br/>\n")
(insert "<li>" title "<br/>\n")))
(aset org-levels-open (1- level) t)
(org-close-par-maybe)
(if target
- (insert (format "<ul>\n<li id=\"%s\">" target)
+ (insert (format "<ul>\n<li id=\"%s\">" remove)
extra-targets title "<br/>\n")
(insert "<ul>\n<li>" title "<br/>\n"))))
(aset org-levels-open (1- level) t)
--
1.7.2.3
[-- Attachment #5: Type: text/plain, Size: 1615 bytes --]
> - Carsten
>
>>
>> (This bug is unrelated to any of the previous internal link bugs
>> that I
>> have reported)
>>
>> # Input file
>>
>> #+OPTIONS: H:1
>>
>> * Links
>> ** Targets
>>
>> *** Fuzzy Target
>>
>> *** Target with CUSTOMID
>> :PROPERTIES:
>> :CUSTOM_ID: aabbccddeeff
>> :END:
>>
>> *** Dedicated Target
>> # <<Dedicated Target>>
>>
>> *** <<<Radioed Target>>>
>>
>> ** References
>>
>> *** References to Fuzzy Target
>> This is a link to [[Fuzzy Target]].
>>
>> *** References to CUSTOMID links
>> This link to [[#aabbccddeeff][CUSTOMID Target]] is broken.
>>
>> *** References to Dedicated Target
>> There is a link to nodesc [[Dedicated Target]] here. There is a link
>> to [[Dedicated%20Target][Jump to Dedicated Target]] here.
>>
>> *** References to Radioed Links
>> This section has references to Radioed Target. One more reference
>> to Radioed Target.
>>
>>
>>
>> #+begin_src html
>> <!-- Headline defined here -->
>> <ul>
>> <li id="sec-1_1_2">
>> <a name="sec-1_1_2" id="sec-1_1_2">
>> </a>
>> Target with CUSTOMID
>> <br/>
>> </li>
>> </ul>
>>
>> <!-- Headline referenced here -->
>> <ul>
>> <li id="sec-1_2_2">
>> References to CUSTOMID links
>> <br/>
>> This link to
>> <a href="#aabbccddeeff">
>> CUSTOMID Target
>> </a>
>> is broken.
>> </li>
>> </ul>
>> #+end_src
>>
>>
>> Jambunathan K.
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[-- Attachment #6: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2010-11-08 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 17:53 Broken CUSTOMID links Jambunathan K
2010-11-06 19:36 ` Carsten Dominik
2010-11-08 13:39 ` Jambunathan K [this message]
2010-11-12 15:50 ` [PATCH 2/2] Fix broken CUSTOM_ID links Carsten Dominik
2010-11-17 13:26 ` Carsten Dominik
2010-11-17 15:22 ` [PATCH: RESUBMITTED] " Jambunathan K
2010-11-17 15:22 ` Jambunathan K
2010-11-21 8:45 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81oca0rl2h.fsf_-_@gmail.com \
--to=kjambunathan@gmail.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).