[bug] Commit 6f8ea8e breaks the build

[bug] Commit 6f8ea8e breaks the build

[Martyn Jago]

Commit 6f8ea8e breaks the build.

> make clean
> make

...returns the error:

--8<---------------cut here---------------start------------->8---

emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-odt.el

In toplevel form:
lisp/org-odt.el:31:13:Error: Cannot open load file: htmlfontify
make: *** [lisp/org-odt.elc] Error 1

--8<---------------cut here---------------end--------------->8---


Best, Martyn

---
Org-mode version 7.7 (release_7.7.674.gc609)
GNU Emacs 24.0.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
 of 2011-08-21 on virtualmac.porkrind.org

Re: [bug] Commit 6f8ea8e breaks the build

[Jambunathan K]

Martyn Jago <martyn.jago@btinternet.com> writes:

> Commit 6f8ea8e breaks the build.

>> make clean
>> make
>
> ...returns the error:
>
>
> emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-odt.el
>
> In toplevel form:
> lisp/org-odt.el:31:13:Error: Cannot open load file: htmlfontify
> make: *** [lisp/org-odt.elc] Error 1

I am using Windows/Cygwin and Emacs-24 pretest builds. org-odt.el
compiles just fine.

--8<---------------cut here---------------start------------->8---
In toplevel form:
org-mouse.el:320:1:Warning: global/dynamic var `rest' lacks a prefix
org-mouse.el:1024:1:Warning: global/dynamic var `_cmd' lacks a prefix
Wrote c:/Documents and Settings/kjambunathan/My Documents/My Data/src/org-mode/lisp/org-mouse.elc
emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-odt.el
Wrote c:/Documents and Settings/kjambunathan/My Documents/My Data/src/org-mode/lisp/org-odt.elc
--8<---------------cut here---------------end--------------->8---

Don't you have htmlfontify.el in your version of Emacs? I thought it is
part of regular Emacs. Could you please check why this is so? May be
some adjustment of load path is required or htmlfontify.el has to be
installed.

>
> Best, Martyn
>
> ---
> Org-mode version 7.7 (release_7.7.674.gc609)
> GNU Emacs 24.0.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
>  of 2011-08-21 on virtualmac.porkrind.org
>
>
>

-- 

Re: [bug] Commit 6f8ea8e breaks the build

[Martyn Jago]

Hi Jambunathan

Jambunathan K <kjambunathan@gmail.com> writes:

> Martyn Jago <martyn.jago@btinternet.com> writes:
>
>> Commit 6f8ea8e breaks the build.
>
>>> make clean
>>> make
>>
>> ...returns the error:
>>
>>
>> emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-odt.el
>>
>> In toplevel form:
>> lisp/org-odt.el:31:13:Error: Cannot open load file: htmlfontify
>> make: *** [lisp/org-odt.elc] Error 1
>
> I am using Windows/Cygwin and Emacs-24 pretest builds. org-odt.el
> compiles just fine.
>


The problem appears to be that htmlfontify.el was not present in
Emacs-23 and Emacs-22 releases. This is a problem since Org-mode is
supposed to build with releases back to Emacs-22. Since my build builds
all versions to ensure against regression, the build failed.

Best, Martyn

 
> In toplevel form:
> org-mouse.el:320:1:Warning: global/dynamic var `rest' lacks a prefix
> org-mouse.el:1024:1:Warning: global/dynamic var `_cmd' lacks a prefix
> Wrote c:/Documents and Settings/kjambunathan/My Documents/My Data/src/org-mode/lisp/org-mouse.elc
> emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-odt.el
> Wrote c:/Documents and Settings/kjambunathan/My Documents/My Data/src/org-mode/lisp/org-odt.elc
>
> Don't you have htmlfontify.el in your version of Emacs? I thought it is
> part of regular Emacs. Could you please check why this is so? May be
> some adjustment of load path is required or htmlfontify.el has to be
> installed.
>
>>
>> Best, Martyn
>>
>> ---
>> Org-mode version 7.7 (release_7.7.674.gc609)
>> GNU Emacs 24.0.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
>>  of 2011-08-21 on virtualmac.porkrind.org
>>
>>
>>

Re: [bug] Commit 6f8ea8e breaks the build

[Bastien]

Jambunathan K <kjambunathan@gmail.com> writes:

> Don't you have htmlfontify.el in your version of Emacs? I thought it is
> part of regular Emacs. Could you please check why this is so? May be
> some adjustment of load path is required or htmlfontify.el has to be
> installed.

htmlfontify.el is part of Emacs since version >= 23.2.  See this
log in the ChangeLog.15 file in Emacs:

2009-11-19  Vivek Dasmohapatra  <vivek@etla.org>

	* htmlfontify.el, hfy-cmap.el: New files.

I pushed a fix that checks whether the user is running Emacs >= 23.2
and require htmlfontify.el only if so.

Thanks,

-- 
 Bastien

Re: [bug] Commit 6f8ea8e breaks the build

[Nick Dokos]

Jambunathan K <kjambunathan@gmail.com> wrote:

> Martyn Jago <martyn.jago@btinternet.com> writes:
> 
> > Commit 6f8ea8e breaks the build.
> > ...
> ... 
> Don't you have htmlfontify.el in your version of Emacs? I thought it is
> part of regular Emacs. Could you please check why this is so? May be
> some adjustment of load path is required or htmlfontify.el has to be
> installed.
> 

FWIW, M-x locate-library gives me

Library is file /usr/local/share/emacs/24.0.90/lisp/htmlfontify.elc

so it *is* part of emacs24.

Nick

Re: [bug] Commit 6f8ea8e breaks the build

[Jambunathan K]

Bastien <bzg@altern.org> writes:

> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> Don't you have htmlfontify.el in your version of Emacs? I thought it is
>> part of regular Emacs. Could you please check why this is so? May be
>> some adjustment of load path is required or htmlfontify.el has to be
>> installed.
>
> htmlfontify.el is part of Emacs since version >= 23.2.  See this
> log in the ChangeLog.15 file in Emacs:
>
> 2009-11-19  Vivek Dasmohapatra  <vivek@etla.org>
>
> 	* htmlfontify.el, hfy-cmap.el: New files.
>
> I pushed a fix that checks whether the user is running Emacs >= 23.2
> and require htmlfontify.el only if so.

Thanks Bastien.

I pushed one more fix which does a (require 'htmlfontify nil t) instead
of (require 'htmlfontify).

> Thanks,

Re: [bug] Commit 6f8ea8e breaks the build

[Bastien]

Jambunathan K <kjambunathan@gmail.com> writes:

> I pushed one more fix which does a (require 'htmlfontify nil t) instead
> of (require 'htmlfontify).

Indeed, thanks!

-- 
 Bastien

Re: [bug] Commit 6f8ea8e breaks the build

[Achim Gratz]

Jambunathan K <kjambunathan@gmail.com> writes:
> I pushed one more fix which does a (require 'htmlfontify nil t) instead
> of (require 'htmlfontify).

Requiring htmlfontify seems to spawn a shell while byte-compiling (I've
not looked further into why it would do this).  That makes is a bit
difficult to set up correctly when "cross-compiling" from a Cygwin make
with an NTemacs -- SHELL is having a Cygwin/UNIX path, and NTemacs then
does not understand how to start the shell.  I've managed to get around
this by modifying the SHELL variable before starting NTemacs from make,
but it's not something very obvious to do.  Do you really require the
package to be loaded (i.e. actually run compile-time macros from
htmlfontify) or do you just need to have the functions and variables
declared?  If the latter, please consider removing the rquire statement
and replacing with the appropriate declarations.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [bug] Commit 6f8ea8e breaks the build

[Jambunathan K]

Achim Gratz <Stromeko@nexgo.de> writes:

> Requiring htmlfontify seems to spawn a shell while byte-compiling 

> please consider removing the rquire statement and replacing with the
> appropriate declarations.

Done.

--