emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Improve visibility for bad links
@ 2012-05-16  8:00 Sebastien Vauban
  2012-05-16 15:00 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Sebastien Vauban @ 2012-05-16  8:00 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

From 1ee99dc8bfe790f691d159048f90d741daa7d231 Mon Sep 17 00:00:00 2001
From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Date: Wed, 16 May 2012 09:57:03 +0200
Subject: [PATCH] Improve visibility for bad links

	* org-latex.el (org-export-latex-links): Improve visibility
	for bad links.

Use black text on red background instead of "texttt".

TINYCHANGE

---
 lisp/org-latex.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/org-latex.el b/lisp/org-latex.el
index 9f58456..fecad5a 100644
--- a/lisp/org-latex.el
+++ b/lisp/org-latex.el
@@ -2329,7 +2329,8 @@ The conversion is made depending of STRING-BEFORE and STRING-AFTER."
 	       (save-match-data
 		 (funcall fnc (org-link-unescape raw-path) desc 'latex))))
 
-	     (t (insert "\\texttt{" desc "}")))))))
+	     ;; bad link
+	     (t (insert "\\colorbox{red}{" desc "}")))))))
 
 
 (defun org-export-latex-format-image (path caption label attr &optional shortn)
-- 
1.7.9

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Improve visibility for bad links
  2012-05-16  8:00 Improve visibility for bad links Sebastien Vauban
@ 2012-05-16 15:00 ` Nicolas Goaziou
  2012-05-17  6:07   ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2012-05-16 15:00 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: public-emacs-orgmode-mXXj517/zsQ



Hello,

"Sebastien Vauban"
<wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:

> From 1ee99dc8bfe790f691d159048f90d741daa7d231 Mon Sep 17 00:00:00 2001
> From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
> Date: Wed, 16 May 2012 09:57:03 +0200
> Subject: [PATCH] Improve visibility for bad links
>
> 	* org-latex.el (org-export-latex-links): Improve visibility
> 	for bad links.
>
> Use black text on red background instead of "texttt".

I'd rather introduce a variable to customize this. In my opinion, color
in LaTeX output doesn't sound right as a default value.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Improve visibility for bad links
  2012-05-16 15:00 ` Nicolas Goaziou
@ 2012-05-17  6:07   ` Bastien
  0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2012-05-17  6:07 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: public-emacs-orgmode-mXXj517/zsQ, Sebastien Vauban



Hi Sébastien and Nicolas,

Nicolas Goaziou <n.goaziou@gmail.com> writes:

>> From 1ee99dc8bfe790f691d159048f90d741daa7d231 Mon Sep 17 00:00:00 2001
>> From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
>> Date: Wed, 16 May 2012 09:57:03 +0200
>> Subject: [PATCH] Improve visibility for bad links
>>
>> 	* org-latex.el (org-export-latex-links): Improve visibility
>> 	for bad links.
>>
>> Use black text on red background instead of "texttt".
>
> I'd rather introduce a variable to customize this. In my opinion, color
> in LaTeX output doesn't sound right as a default value.

Agreed.  There is now `org-export-latex-link-with-unknown-path-format',
which defaults to the current value.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-17  6:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-16  8:00 Improve visibility for bad links Sebastien Vauban
2012-05-16 15:00 ` Nicolas Goaziou
2012-05-17  6:07   ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).