From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sIqRJDJ2PWF9mQAAgWs5BA (envelope-from ) for ; Sun, 12 Sep 2021 05:38:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GQcpIDJ2PWEBcAAAB5/wlQ (envelope-from ) for ; Sun, 12 Sep 2021 03:38:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C049F8410 for ; Sun, 12 Sep 2021 05:38:25 +0200 (CEST) Received: from localhost ([::1]:46212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPGK0-0006LS-PI for larch@yhetil.org; Sat, 11 Sep 2021 23:38:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPGJZ-0006LK-VG for emacs-orgmode@gnu.org; Sat, 11 Sep 2021 23:37:57 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:35707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPGJX-00015T-US for emacs-orgmode@gnu.org; Sat, 11 Sep 2021 23:37:57 -0400 Received: by mail-pf1-x429.google.com with SMTP id j16so5622646pfc.2 for ; Sat, 11 Sep 2021 20:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+UhP06dwswQE49tCh1XGlmQopGUFPd3e+X88kd5eMtk=; b=SFkdS7B7D090CoDx3fFMg3Xq6jNADGH3zkwqzuuCJmFav9qIO8+PMlDtiMfpvce5oL 5ci6yXmpWNKPunyJMKqJRLYwKRYRr+p+QC8bCAejzV/L4csgZpTjthY8N/Vm67c84z1M fGjWpuVPRp/i5oAKT+jdb0oR/711wHknJPBarSUfM8T8i1ZBSTSthTb+3JFLzSFJWuuf B8byvZ5GTFrseVuz1xlZjR4tluk37a/XKF01+jO+b9sUH/7YESGPkW4GN7V1Y75zNXIB EadjQAPir00cVsSWHFgdFm7nEcjbX6FcRS5g3P9Cavg8Ne5iwq0zR4LbJaPttLhr+5Ox x5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+UhP06dwswQE49tCh1XGlmQopGUFPd3e+X88kd5eMtk=; b=rpGLXXyezHla+taY5AGcNpVHzxNCNglaQgczIPeVwKnOtUhMxOELbsyptA6xk+DtV8 Ivq3L8x2AGDS3t4onJIIimJYqGbh/bjnbJCcG78/j2EGbnXzskkmBwP4LY0qed8PVwBk KyuUxjc3JhDQYojw0fADGHrNUSQE9q2YWSp7kMMT2uz/n/NCibQ9erwg9Tcev8MdAW1V xGmqDLPzsjK7+rw9GZGQi0q0zmpF8FLRe/cBCMhULqrm65rxb9UmhKkIF0p8PYHBczpb f2w5tRVuLJ/LhtBz/wIaBrgdl6gh3N697ZarvKwm9Vn9+x2E76S44OclCyJlu0SpNAbU wrcQ== X-Gm-Message-State: AOAM530QKVLzLVL/UzFuDWfGTqEzrKGi3HcZDO5fTiWtZ8ALlMo1/wuw 9UUeo4Hje9HkQF0rRg/Ld/qDkg== X-Google-Smtp-Source: ABdhPJwkcKr1a5ocdzjgQ9weKx2wJOUUfJUoYLT2yUfhRgdJRfl0m5Vwo1z41WYyXcmSbL3NPOfilw== X-Received: by 2002:a05:6a00:2352:b0:40b:2031:4827 with SMTP id j18-20020a056a00235200b0040b20314827mr5030655pfj.6.1631417872519; Sat, 11 Sep 2021 20:37:52 -0700 (PDT) Received: from localhost ([2600:1700:7270:7d1f:fa59:71ff:fe00:10cc]) by smtp.gmail.com with ESMTPSA id z131sm2985830pfc.159.2021.09.11.20.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 20:37:52 -0700 (PDT) From: Allen Li To: No Wayman Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] References: <87a6l4b0bx.fsf@gmail.com> <80pmtqp2wx.fsf@felesatra.moe> <87ilzhjwkk.fsf@gmail.com> <80mtoqttpu.fsf@felesatra.moe> <87fsuhi7o2.fsf@gmail.com> Date: Sat, 11 Sep 2021 20:37:51 -0700 In-Reply-To: <87fsuhi7o2.fsf@gmail.com> (No Wayman's message of "Mon, 06 Sep 2021 19:23:36 -0400") Message-ID: <80v936qx9s.fsf@felesatra.moe> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=darkfeline@felesatra.moe; helo=mail-pf1-x429.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631417906; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+UhP06dwswQE49tCh1XGlmQopGUFPd3e+X88kd5eMtk=; b=NHXw0uE0l7GSjMX++2pYAecM+ydwrVIqOw4q3D+d/KKcO7zr77LWVUvhiC/8ggzSZ3lt6F q/spmRLMziqP0FyJu9IvTEe6bqVz1ViTHJoZ7jUZoSMiXB2U+iByy4WO8iv4WVS/cwvuDg IMoYl/tQKsN8eRtBMuzCX9vWqLf/OylA4nOmZQpmHGCyxgpg5PQsqRgPkouI/Wst40eAS9 BwWsnSMpNlkdjnfih1t3Jms25y7aRVmMiFvfQlUnzFdtVFPhPB6ja+VG6Ti7AQCaZz6LnR ueg5xCH45Ue67rk9Gz868vAz7AVpdIGARietJhtDPrIwYExGXU5UDHBLM2B7iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631417906; a=rsa-sha256; cv=none; b=ZLILx6bpV/ryO3/AyN5bSPYgWOT3zcCBdG8w+XxH7+r2/g8CAQwamf2796edXGtY70Pwnp JRm56iunEqNBMgtvPzPcGfdhvPhz1xdj3OQ1TS4KxT0Wwt668xG8NT6SpOJ4Ud0Dz9/uBk j/WigsYHoYcPtF5CkBRkoLWC1sJ1NXxOz6+MIWvTOwHeS3E9xETYHESffTkwZxVtd1zB4i COrjJCxy/CfF0B50XkyMAzgymk0OhMNMApzI05KHVcB7lK68ef4cUmKr/xCourvxn5MCJd AlaXr51XV0ABNeDGlO80aT6JFTVqVpr8flp90XXq82+qR4KhfxZe//6+urIAvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=felesatra-moe.20150623.gappssmtp.com header.s=20150623 header.b=SFkdS7B7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=felesatra-moe.20150623.gappssmtp.com header.s=20150623 header.b=SFkdS7B7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C049F8410 X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: W6WfQb6JUZfc No Wayman writes: >> Yes, I think using only ":" and "," is the best default option. I >> still >> don't think there is a need to make it customizable (I doubt anyone >> is >> typing tags separated with ! or @ or #), but I suppose >> there's minimal harm from doing so. > > I don't see the need to prevent customization here, either. > There may be use cases we don't anticiapte and it adds very little in > the way of maitenance. > Consider if the author of crm.el decided to hardcode the separator. > Your original patch would not have been so trivial. crm.el is a library whose purpose is to provide a customizable completion API. That's not comparable to Org mode's tag setting commands. > >> I am -0.5 on showing the delimiters since this is not conventional >> for >> completing-read-multiple, especially after we add support for "," >> like >> most other uses of completing-read-multiple. It needlessly inflates >> the >> length of the prompt. > > I don't know what you mean by -0.5, but I wouldn't say it's needless. > `org-todo-list' adds the following to the prompt: > >> "Keyword (or KWD1|KWD2|...): " > > We're talking a handful of characters at most. e.g. > >> "Tags (: , to delimit): " > > Actually shorter than what `org-todo-list' does now. > I'm open to suggestions on improving that prompt format as well. -0.5 means slightly against (+1 means agree and -1 means disagree). > So it looks like the remaining issue is whether or not it's worth > displaying the tag delimiters in the prompt. I'll think on it some > more and give it some time to see if anyone else has any arguments in > favor or against the idea. If I don't see anything by the weekend, > I'll amend the patch with the changes suggested above. I don't want to bikeshed it further since it is not that important and not worth either of our time. I have already stated my reasons that I would personally not add these things, but it does not bother me enough, nor is it significant enough to spend more time on. Whether to make the delimiters customizable: No, because I don't think there's a need. Maybe one Org mode user will need it and they can define their own command. Whether to display separators in prompt: No, because both , and : are intuitive, and also no if delimiters are customizable since the user knows what the delimiters are (since they set them).