From: "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [PATCH] Don't force the <style> tag to be present in `org-agenda-export-html-style'
Date: Wed, 19 Sep 2012 20:54:01 +0200 [thread overview]
Message-ID: <80d31h973q.fsf@somewhere.org> (raw)
In-Reply-To: 87a9wmpa8i.fsf@bzg.ath.cx
Hi Bastien,
Bastien wrote:
> thanks for the patch.
>
> matching against "<style>" is wrong, but matching against "style"
> looks still useful to me.
>
> What do you think?
I don't think so. Let me re-explain...
I want a correct HTML header, with a link to an external CSS file, such as:
--8<---------------cut here---------------start------------->8---
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN">
<!-- Created by htmlize-1.36 in css mode. -->
<html>
<head>
<title>Summary Review - Aviva ETE</title>
<link rel="stylesheet" type="text/css" href="org-agenda-views.css"/>
</head>
--8<---------------cut here---------------end--------------->8---
If I set the variable `org-agenda-export-html-style' to the string I want:
#+begin_src emacs-lisp
(setq org-agenda-export-html-style
"<link rel=\"stylesheet\" type=\"text/css\" href=\"org-agenda-views.css\"/>")
#+end_src
it will be *ignored*... because there is no word `style' (with or without the
angular brackets)!
I don't understand /why such a test was made/, but clearly (with the above
example), we can't force the user to wrap the <link/> inside <style> tags;
otherwise, the browser does not look for the external CSS file.
The only solution is:
- don't check for `style'
- allow a pure `link' tag to be inserted in the header
what my patch does.
Best regards,
Seb
--
Sebastien Vauban
next prev parent reply other threads:[~2012-09-19 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 10:30 [PATCH] Don't force the <style> tag to be present in `org-agenda-export-html-style' Sebastien Vauban
2012-09-19 10:39 ` Bastien
2012-09-19 18:54 ` Sebastien Vauban [this message]
2012-09-19 19:16 ` Sebastien Vauban
2012-09-19 19:29 ` Achim Gratz
2012-09-19 19:54 ` Sebastien Vauban
2012-09-19 22:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d31h973q.fsf@somewhere.org \
--to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).