From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?S=C3=A9bastien_Vauban?= <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
Subject: Re: [PATCH] Re: TODO state change from TODO to DONE blocked
Date: Fri, 04 Mar 2011 22:54:24 +0100
Message-ID: <80aahamu0f.fsf@somewhere.org>
References: <80lj15yab6.fsf@somewhere.org> <80wrkp4dwo.fsf@somewhere.org>
	<87pqqeafov.fsf@gnu.org> <80hbbjq690.fsf@somewhere.org>
	<80d3m6rk6e.fsf_-_@somewhere.org> <87sjv2bu5w.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode-mXXj517/zsQ@public.gmane.org>
List-Help: <mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org

Hi Bastien,

Bastien wrote:
> Hi S=C3=A9bastien,
>
> S=C3=A9bastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>
>>> - if the output message could be updated to make it clear what the reas=
on is,
>>>   or can be?
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 3a07cfd..fb60bc6 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -10927,7 +10927,10 @@ For calling through lisp, arg is also interpret=
ed in the following way:
>>  			(run-hook-with-args-until-failure
>>  			 'org-blocker-hook change-plist)))
>>  	      (if (interactive-p)
>> -		  (error "TODO state change from %s to %s blocked" this state)
>> +		  (error (concat "TODO state change from %s to %s blocked "
>> +				 "(because of undone child, or "
>> +				 "parent with ORDERED property and undone prior sibling)")
>> +			 this state)
>
> I'm not in favor of displaying such a long error message: I find it not
> easily readable, and it raises too many potential causes for the error.

I know, too long.

> The user already knows about these various reasons by reading the
> docstring of `org-enforce-todo-dependencies', which defaults to `nil'.

It was a matter of allowing people to loose less time next time they'll see
that message.

> Thanks anyway for the patch!

Not a problem. Just discard it.

Best regards,
  Seb

--=20
S=C3=A9bastien Vauban