From: Carsten Dominik <carsten.dominik@gmail.com>
To: "Rémi Vanicat" <vanicat@debian.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Org attach: use vc to find the git dir if it exists
Date: Sat, 31 Aug 2013 15:58:36 +0200 [thread overview]
Message-ID: <80F28573-BB41-43C0-B0D8-9F7EAD39A197@gmail.com> (raw)
In-Reply-To: <87txiv2g3t.dlv@gobelin.at.home>
Applied, thank you Remi.
- Carsten
On 12.8.2013, at 15:28, Rémi Vanicat <vanicat@debian.org> wrote:
> Org attach use to fail to commit the attached file in git or git annex
> when the .git repository is not in the data sub-directory.
>
> This new code will use vc-git to find the .git file, and from this do
> what is needed for committing file into git or git annex.
>
> ---
> lisp/org-attach.el | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-attach.el b/lisp/org-attach.el
> index faefa6b..9bf3cda 100644
> --- a/lisp/org-attach.el
> +++ b/lisp/org-attach.el
> @@ -261,14 +261,15 @@ the ATTACH_DIR property) their own attachment directory."
> (defun org-attach-commit ()
> "Commit changes to git if `org-attach-directory' is properly initialized.
> This checks for the existence of a \".git\" directory in that directory."
> - (let ((dir (expand-file-name org-attach-directory))
> - (changes 0))
> - (when (file-exists-p (expand-file-name ".git" dir))
> + (let* ((dir (expand-file-name org-attach-directory))
> + (git-dir (vc-git-root dir))
> + (changes 0))
> + (when git-dir
> (with-temp-buffer
> (cd dir)
> (let ((have-annex
> (and org-attach-git-annex-cutoff
> - (file-exists-p (expand-file-name ".git/annex" dir)))))
> + (file-exists-p (expand-file-name "annex" git-dir)))))
> (dolist (new-or-modified
> (split-string
> (shell-command-to-string
> --
> 1.8.4.rc2
>
>
>
prev parent reply other threads:[~2013-08-31 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:28 [PATCH] Org attach: use vc to find the git dir if it exists Rémi Vanicat
2013-08-31 13:58 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80F28573-BB41-43C0-B0D8-9F7EAD39A197@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=vanicat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).