[Babel] Better messages for code block execution

[Babel] Better messages for code block execution

[Sébastien Vauban]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

Hi,

Here are a couple of better (IMHO) messages for what occurs during source
block execution:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: better-messages.patch --]
[-- Type: text/x-patch, Size: 696 bytes --]

diff --git a/lisp/ob.el b/lisp/ob.el
index dd285db..05bb320 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
 	  (indent-rigidly beg end indent))))
     (if (= (length result) 0)
 	(if (member "value" result-params)
-	    (message "No result returned by source block")
-	  (message "Source block produced no output"))
-      (message "finished"))))
+	    (message "Source block returned no value.")
+	  (message "Source block produced no output."))
+      (message "Inserted results of source block execution."))))
 
 (defun org-babel-remove-result (&optional info)
   "Remove the result of the current source block."

[-- Attachment #3: Type: text/plain, Size: 50 bytes --]


Best regards,
  Seb

-- 
Sébastien Vauban

[-- Attachment #4: Type: text/plain, Size: 222 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

[Babel] Better messages for code block execution

[Sébastien Vauban]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

Hi,

Here are a couple of better (IMHO) messages for what occurs during source
block execution:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: better-messages.patch --]
[-- Type: text/x-patch, Size: 696 bytes --]

diff --git a/lisp/ob.el b/lisp/ob.el
index dd285db..05bb320 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
 	  (indent-rigidly beg end indent))))
     (if (= (length result) 0)
 	(if (member "value" result-params)
-	    (message "No result returned by source block")
-	  (message "Source block produced no output"))
-      (message "finished"))))
+	    (message "Source block returned no value.")
+	  (message "Source block produced no output."))
+      (message "Inserted results of source block execution."))))
 
 (defun org-babel-remove-result (&optional info)
   "Remove the result of the current source block."

[-- Attachment #3: Type: text/plain, Size: 50 bytes --]


Best regards,
  Seb

-- 
Sébastien Vauban

[-- Attachment #4: Type: text/plain, Size: 222 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [Babel] Better messages for code block execution

[Eric Schulte]

Hi Seb,

Thanks for the suggestion, I've just applied a slight alteration of
these improved messages.

#+begin_src diff
  diff --git a/lisp/ob.el b/lisp/ob.el
  index dd285db..fe392d9 100644
  --- a/lisp/ob.el
  +++ b/lisp/ob.el
  @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
            (indent-rigidly beg end indent))))
       (if (= (length result) 0)
          (if (member "value" result-params)
  -	    (message "No result returned by source block")
  -	  (message "Source block produced no output"))
  -      (message "finished"))))
  +	    (message "Code block returned no value.")
  +	  (message "Code block produced no output."))
  +      (message "Code block evaluation complete."))))

   (defun org-babel-remove-result (&optional info)
     "Remove the result of the current source block."
#+end_src

Best -- Eric

Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Hi,
>
> Here are a couple of better (IMHO) messages for what occurs during source
> block execution:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index dd285db..05bb320 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
>  	  (indent-rigidly beg end indent))))
>      (if (= (length result) 0)
>  	(if (member "value" result-params)
> -	    (message "No result returned by source block")
> -	  (message "Source block produced no output"))
> -      (message "finished"))))
> +	    (message "Source block returned no value.")
> +	  (message "Source block produced no output."))
> +      (message "Inserted results of source block execution."))))
>  
>  (defun org-babel-remove-result (&optional info)
>    "Remove the result of the current source block."
>
> Best regards,
>   Seb