From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QFWPOgu75mC/FwAAgWs5BA (envelope-from ) for ; Thu, 08 Jul 2021 10:44:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6IpbNgu75mAYZAAA1q6Kng (envelope-from ) for ; Thu, 08 Jul 2021 08:44:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CA5D2594D for ; Thu, 8 Jul 2021 10:44:59 +0200 (CEST) Received: from localhost ([::1]:53746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1PeS-0006QX-L9 for larch@yhetil.org; Thu, 08 Jul 2021 04:44:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Pe7-0006QM-7M for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:44:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:51809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Pe5-0008NR-1M for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:44:35 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id BD152240028 for ; Thu, 8 Jul 2021 10:44:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.eu; s=2017; t=1625733867; bh=5b/06YhT9BvtuK5tDohYN/EkxfTF4J0yyQzh/VYAMB0=; h=Subject:To:From:Date:From; b=q7dBo/jZ+D9xKB+nFmhkdIGjT5W76cpE5GNnCd3zlPBNO9ZA9/6y5XpPVdIdAFlJy iJmt4Ronj1cHn3+FwNGESAfueCnwcVA2U036W+2HebQLIcN070fzMn0b3P3MXkzgZl dwLgyeqeq2m2r6wvu2kJ+LwUecoOIjU3pJIp5rYrXmvIkqr3ulFbDlm28iTEKNagO6 9OLRC8mV6WZYw4pBFPevk4okWe+0+X0V1kG+NmWZGjMk+4lMR9810nXnHzg5gO6K9L icnml84ame1sj52XvgQoEQTyUkgNia+bBFHK+yL1E4pNPArO4hygZVdyEywpjL3c8S kKgDrWjGYYJhg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GL8wq1KH0z6tmG; Thu, 8 Jul 2021 10:44:26 +0200 (CEST) Subject: Re: [PATCH] Do not throw error when parameter of :tangle is not a string To: Jacopo De Simoi , Org-mode Org-Mode References: <7267271.EvYhyI6sBW@bl4ckspoons> From: =?UTF-8?Q?S=c3=a9bastien_Miquel?= Message-ID: <7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu> Date: Thu, 8 Jul 2021 08:44:26 +0000 MIME-Version: 1.0 In-Reply-To: <7267271.EvYhyI6sBW@bl4ckspoons> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr Received-SPF: pass client-ip=185.67.36.65; envelope-from=sebastien.miquel@posteo.eu; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sebastien.miquel@posteo.eu Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625733899; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=4jhVQuE2cUxHOe9ziBtdc2spavDnMeC4Wjda7dzvFI8=; b=Ap5rKvGDgaIoiSvEzq1CIeuYz5pAA6Sex7X6ZDBJr7gIN286+qpFqD/ai5O1dTkN2Dm2gL KOucDUi3uwYat3cIu8xIv9jC1IskyfXldozH9ZAyt7LnWjU5+AvRti8BFmVZRD7zkTY12i vGCLH7xxMSLccDYj2zIF7CW+FZGif3CQkku9LrKkKflSO4qIPYneL/HMoR1NNcCJ3FPOJx jr0njCEGuUI2WIdSsyrAMEJ8sTZftRu0o1SWMqSPl0QXFgI1nfofaal21EZUwZAp/KbsJi 1HDVP09BWJt6IyCLkk09WhCtKKBQo5gS4LpTkAENnWgGxVQT/LAa8ymTv0DpxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625733899; a=rsa-sha256; cv=none; b=XSH4cU4Zhq3pt8XWGUv1NTpwwSlMXSnq2g6/1vED8EMQv5ErJpkSzXJNe1X0D4HhgMPmmC 1YeGD6RNZxpt7CPbsvqh1ipg5uX34UhTtb+ZM9TeZ6eIcWhrXp15ZG8s9TRJ/Zvj+u5gPg 4tH9ltDPSsoScdVoTJgBmeF0tDdqXSOw7f8oP0DnrBYHaxPU98NbePjto/GMO7ZNvCVyNX 0u8W7MGRGVhZnhpcx8lHc1862/kRE82zUltwpT/43tjhVTWVLnChofJ1wq4xG6TEqzIvdn 20NlSqloQTcvXwIvncjJESToRBBS9tbr2cALWkpawsWywvfoBDORB5pEsySBNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.eu header.s=2017 header.b="q7dBo/jZ"; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.eu header.s=2017 header.b="q7dBo/jZ"; dmarc=pass (policy=none) header.from=posteo.eu; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 1CA5D2594D X-Spam-Score: -3.11 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1mlSnTQxn3AW Hi, Jacopo De Simoi writes: > in the current master branch, if the parameter :tangle of a src block is not > a string, tangling fails by throwing an error when calling `file-name- > directory' This patch checks if the parameter is a string before calling > `file-name-directory'. > > This makes construct such as :tangle (when condition-applies "filename") work > again (as they did a few versions ago…) Thanks for the patch. It looks good to me (had to run `dos2unix' to apply). To clarify, it fixes `:tangle (when condition-applies "filename")' when the condition doesn't apply, such as `(when nil "filename")'. Regards, -- Sébastien Miquel