Tasks under COMMENT section are added to appt

Tasks under COMMENT section are added to appt

[Daniel Clemente]

Hi,
  the agenda view ignores tasks which have a COMMENT keyword in the headline (or are children of a such headline):

* COMMENT Past activities
** DONE Go do something, <2007-10-25 Do 18:00 +1w>
...
** DONE Something else I did
   SCHEDULED: <2008-12-11 dj 19:45>


  But I was surprised to find them added as appointments to appt after an (org-agenda-to-appt). Both were added (you can check it with appt-delete) and they will be displayed from now on.
  I think they should be always be ignored by default.


  Thanks,

Daniel

Re: Tasks under COMMENT section are added to appt

[Carsten Dominik]

Hi Daniel,

could you please try if the following patch fixes this problem?

Thanks.

- Carsten


diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index ffcabde..25f2baa 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5627,6 +5627,7 @@ belonging to the \"Work\" category."
  		 (time-to-days (current-time))))
  	 (files (org-agenda-files 'unrestricted)) entries file)
      ;; Get all entries which may contain an appt
+    (org-prepare-agenda-buffers files)
      (while (setq file (pop files))
        (setq entries
  	    (append entries

On Dec 11, 2008, at 7:29 PM, Daniel Clemente wrote:

>
> Hi,
>  the agenda view ignores tasks which have a COMMENT keyword in the  
> headline (or are children of a such headline):
>
> * COMMENT Past activities
> ** DONE Go do something, <2007-10-25 Do 18:00 +1w>
> ...
> ** DONE Something else I did
>   SCHEDULED: <2008-12-11 dj 19:45>
>
>
>  But I was surprised to find them added as appointments to appt  
> after an (org-agenda-to-appt). Both were added (you can check it  
> with appt-delete) and they will be displayed from now on.
>  I think they should be always be ignored by default.
>
>
>  Thanks,
>
> Daniel
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Tasks under COMMENT section are added to appt

[Daniel Clemente]

Carsten Dominik <dominik@science.uva.nl> writes:

> could you please try if the following patch fixes this problem?

A simple patch, and it works! Thanks for commiting it.

--
Daniel


>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index ffcabde..25f2baa 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5627,6 +5627,7 @@ belonging to the \"Work\" category."
>  		 (time-to-days (current-time))))
>  	 (files (org-agenda-files 'unrestricted)) entries file)
>      ;; Get all entries which may contain an appt
> +    (org-prepare-agenda-buffers files)
>      (while (setq file (pop files))
>        (setq entries
>  	    (append entries
>