emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Andreas Seltenreich <seltenreich@gmx.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] org-agenda-goto should push mark before moving point
Date: Fri, 23 Apr 2010 08:35:29 +0200	[thread overview]
Message-ID: <7BFD3F0D-0357-4E26-83C9-27E9B0B7B200@gmail.com> (raw)
In-Reply-To: <871ve7433n.fsf@gate450.dyndns.org>

Hi Andreas,

On Apr 22, 2010, at 10:57 PM, Andreas Seltenreich wrote:

> Hi,
>
> many commands in Emacs that move the point long distances push the  
> mark
> so you can go back using C-u C-<SPC>.  org-agenda-goto doesn't do  
> this,
> and I found it a bit annoying that I have to navigate the outline  
> again
> to find back to where the point was before using the Agenda.
>
> Patch attached.
>
> regards,
> andreas
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index c68038d..9f35069 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -6082,6 +6082,7 @@
> 	 (pos (marker-position marker)))
>     (switch-to-buffer-other-window buffer)
>     (widen)
> +    (push-mark)
>     (goto-char pos)
>     (when (org-mode-p)
>       (org-show-context 'agenda)

I am no sure this is the right thing to do.  Because, often you will  
show *many* places from the agenda before going back to the buffer.   
Org-agenda-goto is called by many other functions like org-agenda- 
show, org-agenda-recenter etc.

This might work better:

(defun my-org-agenda ()
    (interactive)
    (push-mark)
    (call-interactively 'org-agenda))

(define-key global-map "\C-ca" 'my-org-agenda)

Maybe you can test this and report back?

- Carsten

>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

  reply	other threads:[~2010-04-23  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 20:57 [patch] org-agenda-goto should push mark before moving point Andreas Seltenreich
2010-04-23  6:35 ` Carsten Dominik [this message]
2010-04-23  8:42   ` Andreas Seltenreich
2010-04-27 10:00     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7BFD3F0D-0357-4E26-83C9-27E9B0B7B200@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=seltenreich@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).