We need to widen before closing edit buffers

We need to widen before closing edit buffers

[Dan Davison]

At the moment, if we use narrowing in source code edit buffers, then we
need to be very careful that we widen before exiting with C-c '. So
shall we change org-src as below?

Dan

diff --git a/lisp/org-src.el b/lisp/org-src.el
index 1d155cc..a11fac2 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -515,6 +515,7 @@ the language, a switch telling if the content should be in a single line."
   (interactive)
   (unless org-edit-src-from-org-mode
     (error "This is not a sub-editing buffer, something is wrong..."))
+  (widen)
   (let* ((beg org-edit-src-beg-marker)
         (end org-edit-src-end-marker)
         (ovl org-edit-src-overlay)

Re: We need to widen before closing edit buffers

[Carsten Dominik]

Hi Dan,

Yes, please check this in.  Thanks.

- Carsten

On Feb 9, 2010, at 8:19 PM, Dan Davison wrote:

> At the moment, if we use narrowing in source code edit buffers, then  
> we
> need to be very careful that we widen before exiting with C-c '. So
> shall we change org-src as below?
>
> Dan
>
> diff --git a/lisp/org-src.el b/lisp/org-src.el
> index 1d155cc..a11fac2 100644
> --- a/lisp/org-src.el
> +++ b/lisp/org-src.el
> @@ -515,6 +515,7 @@ the language, a switch telling if the content  
> should be in a single line."
>   (interactive)
>   (unless org-edit-src-from-org-mode
>     (error "This is not a sub-editing buffer, something is wrong..."))
> +  (widen)
>   (let* ((beg org-edit-src-beg-marker)
>         (end org-edit-src-end-marker)
>         (ovl org-edit-src-overlay)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten