From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user
Date: Fri, 14 Aug 2009 20:49:40 +0200 [thread overview]
Message-ID: <79FD903D-1CA3-4208-A25D-AB858BD7456E@gmail.com> (raw)
In-Reply-To: <1250274503-12703-1-git-send-email-bernt@norang.ca>
Hi Bernt,
the reason for the "prompt" was more documentation, so that
the user knows what is happening. But I can see that this
get annoying when you know what you are doing.
I have applied you patch, but added a message after it that
explains what the key did. I guess this is more agreeable?
- Carsten
On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote:
> This removes the unnecessary prompt to redisplay the agenda view with
> inactive timestamps. If you hit [ or ] you immediately get the
> inactive timestamp view in the daily/weekly agenda view.
>
> You can redisplay without these timestamps by simply hitting 'g'.
> ---
> Hi Carsten,
>
> This patch is available at git://git.norang.ca/org-mode for-carsten
>
> I'm not sure if this prompt I'm removing is really totally useless.
> There
> are similar prompts for other agenda modes which I haven't tried out
> yet
> with [ and ] so I left those alone.
>
> Regards,
> Bernt
>
>
> lisp/org-agenda.el | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index fba7014..4f2f41c 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not
> match for selection of an entry."
> (defun org-agenda-manipulate-query (char)
> (cond
> ((memq org-agenda-type '(timeline agenda))
> - (if (y-or-n-p "Re-display with inactive time stamps included? ")
> - (let ((org-agenda-include-inactive-timestamps t))
> - (org-agenda-redo))
> - (error "Abort")))
> + (let ((org-agenda-include-inactive-timestamps t))
> + (org-agenda-redo)))
> ((eq org-agenda-type 'search)
> (org-add-to-string
> 'org-agenda-query-string
> --
> 1.6.4
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-08-14 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 18:28 [PATCH] Redisplay agenda with inactive timestamps without prompting the user Bernt Hansen
2009-08-14 18:49 ` Carsten Dominik [this message]
2009-08-14 19:22 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79FD903D-1CA3-4208-A25D-AB858BD7456E@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).