From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Highlighting bug with org-agenda-set-restriction-lock Date: Fri, 5 Apr 2013 16:46:19 +0200 Message-ID: <76AEA74E-4457-40A4-9FB7-BEA04700C6AD@gmail.com> References: <87bo9tyvdj.fsf@norang.ca> <890D099A-90BD-4AA5-AD86-E145AF8429A7@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:45778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7uN-0002pq-7u for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO7uH-0007Jh-G7 for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:46:27 -0400 Received: from ezel.ic.uva.nl ([146.50.108.158]:60994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7uH-0007JS-85 for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:46:21 -0400 In-Reply-To: <890D099A-90BD-4AA5-AD86-E145AF8429A7@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org On 5 apr. 2013, at 16:23, Carsten Dominik = wrote: >=20 > On 5 apr. 2013, at 16:12, Carsten Dominik = wrote: >=20 >>=20 >> On 5 apr. 2013, at 15:12, Bernt Hansen wrote: >>=20 >>> Hi, >>>=20 >>> The highlighting has changed for this functionality. I finally = updated >>> to master (1200+ commits) yesterday and when I use C-c C-x < the = entire >>> subtree is now highlighted in bright yellow on my Windows Emacs. >>>=20 >>> GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO >>>=20 >>> Org-mode version 7.9.2 (release_7.9.2-2030-g29a75d @ >>> d:/bin/org-mode/lisp/) >>>=20 >>> This used to highlight only the first heading of the subtree. >>> Highlighting the entire subtree is _very_ distracting and makes = working >>> in the org file on the narrowed subtree difficult (for me). >>>=20 >>> I can fix this by changing the face and completely removing the >>> highlight but I'd prefer the old functionality if that is possible. >>=20 >> This is causes by this commit: >>=20 >> commit aa0e0068de109eef2ac7897c4659d545b351de01 >> Author: Bastien Guerry >> Date: Sat Feb 16 23:09:57 2013 +0100 >>=20 >> org-agenda.el (org-agenda-set-restriction-lock): Put the overlay = until the e >>=20 >> * org-agenda.el (org-agenda-set-restriction-lock): Put the >> overlay until the end of the subtree, not the end of the >> headline. >>=20 >> When the agenda restriction is on, user expect agenda views to = check >> every entry in the subtree. If a user add an entry outside of the >> overlay without noticing it, this entry will not be checked and the >> user will wonder why. Put the end of the overlay at the end of the >> subtree so that the user always knows if the entries she is adding >> are within the current restriction. >>=20 >> We might need to find a less instrusive overlay color, though. >>=20 >>=20 >> So Bastien felt that the entire subtree should have an overlay, but >> maybe a softer color. I would also prefer the highlight just to be >> on the headline as it used to be. >>=20 >> Bastien, how do you feel about reverting this change? I see why >> you did it, but it is not so practical after all if you want to >> work in this mode for extended time. >=20 >=20 > I now also see that the patch did not achieve what the purpose of it = was. The problem is not the end of the overlay, but the position of the = org-agenda-restriction-end marker. Indeed, if you add tasks after this = marker, they will not be included in the search. There is not good = work-around for this I can think of, so it is a problem we will have to = live with. I am fixing this - please let me know if I should revert my fix... Bernt, should be working in master. - Carsten=