From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wvl8G+W3116uEAAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 14:47:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GLMTF+W3116UTgAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 14:47:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DEF5A94038F for ; Wed, 3 Jun 2020 14:47:00 +0000 (UTC) Received: from localhost ([::1]:37596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgUfT-0003qE-Li for larch@yhetil.org; Wed, 03 Jun 2020 10:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgUf2-0003q3-UX for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 10:46:32 -0400 Received: from devianza.investici.org ([198.167.222.108]:58561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgUf0-0007fs-N0 for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 10:46:32 -0400 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 09F74E05CA; Wed, 3 Jun 2020 14:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anche.no; s=stigmate; t=1591195588; bh=73dHAwixLFV1JTAr+5HsYlirJN7fDgJXQBMLalR1BYQ=; h=Subject:To:References:From:Date:In-Reply-To:From; b=jQG26306+D7gpVBx4kuGe8mAsRVpdekemo/TDPbo/6/Q8ZawE9aSjcE+jaM/360Fd mk0KN10hc/I7H36kqw/ZbiYUlUEE74OWQ1ewcyFdv5UqOaoOYZQwGE0HG9gvqX15/u iZolwdoDT65Kmg0OajoQfdwzICy5RnOnuvPYBxpc= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: mariotomo@inventati.org) by localhost (Postfix) with ESMTPSA id 95DE6E05C9; Wed, 3 Jun 2020 14:46:25 +0000 (UTC) Subject: Re: [PATCH] implementing `with' as a list, and respecting `deps' order. To: Kyle Meyer , emacs-orgmode@gnu.org References: <43f4eda9-627d-4b36-7226-37b5458193e8@anche.no> <87sgfcx1hh.fsf@kyleam.com> From: Mario Frasca Message-ID: <75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no> Date: Wed, 3 Jun 2020 09:46:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <87sgfcx1hh.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=198.167.222.108; envelope-from=mario@anche.no; helo=devianza.investici.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 10:46:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=anche.no header.s=stigmate header.b=jQG26306; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: DVf0x7EpQAZo comments on the html page org-contribute.html: is there any mention of git-send-mail in the org-contribute guide?  I don't see it.  nor do I find hints on what to do once you have produced files by git-format-patch.  your "send as attachment" would be useful there.  or a mention of a (unix) command-line sequence, including how to follow-up to previous messages. the procedure mentioned there guides me in creating several patch files, one per commit.  it does not describe the "squashing" you suggested me.  I'm following your guide, but you might want to review the page yourself. the `#commit-messages' section is very clear, I had totally missed it.  sorry. I'm reviewing the commit message accordingly, and will reply to my initial message, attaching the new patch. ciao, MF On 02/06/2020 22:38, Kyle Meyer wrote: > Mario Frasca writes: > >> From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001 >> From: Mario Frasca >> Date: Tue, 2 Jun 2020 15:46:20 +0000 >> Subject: [PATCH] implementing `with' as a list, and respecting `deps' order. > Thank you for sending an updated patch. Unfortunately it looks like it > got mangled by your email client and can't be understood by `git am'. > This list is okay with patches being sent as attachments, and going that > route gets around needing to re-configure your email client or use > git-send-email. > > Before sending the updated patch, please revise the commit message to > more closely match the conventions described at > . Looking over some > recent commits in the repo should give you a good sense for the expected > changelog-like entries as well other style aspects (e.g., it is common > to start the subject with ": " like "org-plot: ..."), which > gives log readers a sense for the general topic affected by the commit. > > Please send the next patch as a follow-up to the original thread to keep > the discussion in one place. > > Thanks again.