emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Mario Frasca <mario@anche.no>
To: Kyle Meyer <kyle@kyleam.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] implementing `with' as a list, and respecting `deps' order.
Date: Wed, 3 Jun 2020 09:46:10 -0500	[thread overview]
Message-ID: <75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no> (raw)
In-Reply-To: <87sgfcx1hh.fsf@kyleam.com>

comments on the html page org-contribute.html:

is there any mention of git-send-mail in the org-contribute guide?  I 
don't see it.  nor do I find hints on what to do once you have produced 
files by git-format-patch.  your "send as attachment" would be useful 
there.  or a mention of a (unix) command-line sequence, including how to 
follow-up to previous messages.

the procedure mentioned there guides me in creating several patch files, 
one per commit.  it does not describe the "squashing" you suggested me.  
I'm following your guide, but you might want to review the page yourself.

the `#commit-messages' section is very clear, I had totally missed it.  
sorry.

I'm reviewing the commit message accordingly, and will reply to my 
initial message, attaching the new patch.

ciao, MF

On 02/06/2020 22:38, Kyle Meyer wrote:
> Mario Frasca writes:
>
>>   From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001
>> From: Mario Frasca <mario@anche.no>
>> Date: Tue, 2 Jun 2020 15:46:20 +0000
>> Subject: [PATCH] implementing `with' as a list, and respecting `deps' order.
> Thank you for sending an updated patch.  Unfortunately it looks like it
> got mangled by your email client and can't be understood by `git am'.
> This list is okay with patches being sent as attachments, and going that
> route gets around needing to re-configure your email client or use
> git-send-email.
>
> Before sending the updated patch, please revise the commit message to
> more closely match the conventions described at
> <https://orgmode.org/worg/org-contribute.html>.  Looking over some
> recent commits in the repo should give you a good sense for the expected
> changelog-like entries as well other style aspects (e.g., it is common
> to start the subject with "<file|area>: " like "org-plot: ..."), which
> gives log readers a sense for the general topic affected by the commit.
>
> Please send the next patch as a follow-up to the original thread to keep
> the discussion in one place.
>
> Thanks again.


  reply	other threads:[~2020-06-03 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 15:57 Mario Frasca
2020-06-03  3:38 ` Kyle Meyer
2020-06-03 14:46   ` Mario Frasca [this message]
2020-06-03 15:03     ` Bastien
2020-06-03 23:50     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no \
    --to=mario@anche.no \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --subject='Re: [PATCH] implementing `with'\'' as a list, and respecting `deps'\'' order.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).