From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: partial-completion-mode error when refiling Date: Thu, 30 Jun 2011 15:34:39 +0200 Message-ID: <757B4199-1E4F-485F-975A-48E49E0330BD@gmail.com> References: <80y60j4u4z.fsf@somewhere.org> <87sjqrk7fo.fsf@gnu.org> <11283.1309437640@alphaville.dokosmarshall.org> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:36905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcHOI-0004iu-9z for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 09:34:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcHOG-0000Op-Dw for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 09:34:46 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:42809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcHOF-0000Oe-QZ for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 09:34:44 -0400 Received: by ewy9 with SMTP id 9so879505ewy.0 for ; Thu, 30 Jun 2011 06:34:42 -0700 (PDT) In-Reply-To: <11283.1309437640@alphaville.dokosmarshall.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: Bastien , emacs-orgmode@gnu.org, Sebastien Vauban On Jun 30, 2011, at 2:40 PM, Nick Dokos wrote: > Bastien wrote: >=20 >> Hi Sebastian, >>=20 >> "Sebastien Vauban" writes: >>=20 >>> When I was trying to refile an extract of an email, I got this: >>>=20 >>> Getting targets...done >>> funcall: Symbol's function definition is void: = partial-completion-mode >>=20 >> thanks for reporting this -- this is indeed something wrong with the = fix >> I made to `org-without-partial-completion' (see my other message to = Paul >> Sexton). =20 >>=20 >> I reverted his patch so you won't see this error again. >>=20 >=20 > I'm not sure that't the problem though: the = org-without-partial-completion > macro is called in a couple of places, once in org-remember.el and = twice > in org.el. I'm not sure how many people still use org-remember, but I = suspect > quite a few. The macro basically says: execute the body while mmaking = sure > that partial-completion-body is off during the execution. At least, = that's > the intent but I haven't thought through the quoting change that Paul = made. >=20 > The calls: >=20 > o org-remember-apply-template: called in the g or G case to complete = tags. > o org.el: in org-icompleting-read. > o org.el: in org-set-tags *around* org-icompleting-read. >=20 > The last one seems superfluous at first sight, but I haven't thought = about > it yet. Yes, this one is superfluous. >=20 > In any case, these seem fairly common situations so I think it is = likely > that the macro has been called hundreds of times (over the whole org = population) > without ill effects. >=20 > OTOH, partial-completion-mode is called explicitly in = org-refile-get-location, > like this: >=20 > (partial-completion-mode nil) This is not a function-calling form, but this is part of a let form, so it just sets the variable partial-completion-mode to nil. In effect, this does indeed turn off partial-completion-mode for the body of the form. >=20 > Could it be that it is really meant to turn *off* partial completion = mode? > In which case, it would be better to call the = org-without-partion-completion > macro here to do the work. >=20 > In any case, this explicit call seems to be more problematic than the = macro. > After all that's what Seb hit. >=20 > Nick >=20 >=20 - Carsten