From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mFLIFI8njV+KLQAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 05:43:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UOYsEI8njV+iCQAA1q6Kng (envelope-from ) for ; Mon, 19 Oct 2020 05:43:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8815940509 for ; Mon, 19 Oct 2020 05:43:42 +0000 (UTC) Received: from localhost ([::1]:57948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUNxM-00073Q-D1 for larch@yhetil.org; Mon, 19 Oct 2020 01:43:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUNjR-0002bZ-J7 for emacs-orgmode@gnu.org; Mon, 19 Oct 2020 01:29:18 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:46223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUNjL-00006T-QH for emacs-orgmode@gnu.org; Mon, 19 Oct 2020 01:29:16 -0400 Received: by mail-ej1-x632.google.com with SMTP id t25so12028843ejd.13 for ; Sun, 18 Oct 2020 22:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubedi-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CgabrrOf+h/bGs4nsy71IGmgIr3x7S0HJ5VkxVq63L0=; b=D/8boZ//l+w89iYWzHKPMBZiINcLBe4YkSXkGHvoiHc9qIu9JOTjd6Z8Z3Zz7VINJE Ojc7oBfWtF+p1dOiRMmYaX+lCocxtPiE49h0JlOLjse1GdacaowZtDaIvZIXjfcVeOEA 2izIf+g7pV4M9JM9DfrHwGidEN3Jwun3Y6vB5CIWCMfe39p52HSISXrQ7tdeIlNgpxnY NPue+bqFlhGYEddV3V9mvcm07cPyr5Bs4VXaM/iWfubhJr1q07NsczDoCmi3HDPGHHJv iPSI2ZJGi4Uk1bFjOHVITDFDZebh2BiT+2CRfDj7tdOsP1J4HVGBEFvuXFszjxviMsNR g9kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CgabrrOf+h/bGs4nsy71IGmgIr3x7S0HJ5VkxVq63L0=; b=YW+Qu/4Bs6IsK2kJGtqU68KGa5+4mSVLdSf2TK+9g99yRsFykTfdZfgSNSV/kiEiV9 Ua0lp7jdKtJuMZSYgQs6ih5qBOgpKBWvQcq1oySsrWBwWTH3yP3USL5wZR0Lj+UVo503 +6laSQw4sbnRn2DbRAN/SJMsUxtpVCCnaPIYKcV8Xle63PZpbzd97DVZrIsKNJxAFpoO tn3zEKWuzlrAVTsucbW4CsOyrMyZej1/HfDJOYfGqOLahVwx5PlWGrk5RCr5jQAKDP+i DrWWhO5vsdaqZ/f7ew0ZCjCwCmGNXjk6cra7T5/4yA0qcaUhRgg+irULfR/i6ceHTtAu 9fsw== X-Gm-Message-State: AOAM531sYCh83GdO/gqUMx1ITgAmnJvNeNOk/9tmELFY25zakAqArQK/ 6wOd9YwuYKV5Bllz1m6aRumTyA== X-Google-Smtp-Source: ABdhPJxt+3qGWmLbbmK2QVDyTPpMXvVpEY4HorcNxYNauyDS3Gv907aR71W9OX0UO9VfFHQLfdrK1w== X-Received: by 2002:a17:907:42fd:: with SMTP id oa21mr15198159ejb.247.1603085348567; Sun, 18 Oct 2020 22:29:08 -0700 (PDT) Received: from gt1.localnet (ip-4-221.hlucinnet.cz. [93.91.243.221]) by smtp.gmail.com with ESMTPSA id g18sm9274338eje.12.2020.10.18.22.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2020 22:29:07 -0700 (PDT) From: Martin Kampas To: Kyle Meyer Subject: Re: Bug: Incorrect done TODO keywords highlighting in column view Date: Mon, 19 Oct 2020 07:29:05 +0200 Message-ID: <7479817.9BdLuGDDFr@gt1> In-Reply-To: <87k0vnz0eh.fsf@kyleam.com> References: <7117090.b6naEkYVYe@gt1> <87k0vnz0eh.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart6662692.yhU5OHXL03" Content-Transfer-Encoding: 7Bit Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=martin.kampas@ubedi.net; helo=mail-ej1-x632.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=ubedi-net.20150623.gappssmtp.com header.s=20150623 header.b=D/8boZ//; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: SXb5VexFf3k4 This is a multi-part message in MIME format. --nextPart6662692.yhU5OHXL03 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Kyle, You are right, I completely forgot about columns view under the "regular" buffers. Updated patch below. BR, Martin >From 288c157ea95e00de4b508e0fd257b51857e097b9 Mon Sep 17 00:00:00 2001 From: Martin Kampas Date: Mon, 19 Oct 2020 07:22:57 +0200 Subject: [PATCH] org-colview: Fix done keywords highlighting in agenda buffers * lisp/org-colview.el (org-agenda-columns): Populate org-done-keywords from org-done-keywords-for-agenda or the done keywords will use the same face as those not-done. --- lisp/org-colview.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index e50a4d7c8..565bdb2dd 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -1586,6 +1586,7 @@ PARAMS is a property list of parameters: (move-marker org-columns-begin-marker (point)) (setq org-columns-begin-marker (point-marker))) (let* ((org-columns--time (float-time)) + (org-done-keywords org-done-keywords-for-agenda) (fmt (cond ((bound-and-true-p org-overriding-columns-format)) -- 2.28.0 --nextPart6662692.yhU5OHXL03 Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Hi Kyle,


You are right, I completely forgot about columns view under the "regular" buffers. Updated patch below.


BR,

Martin


From 288c157ea95e00de4b508e0fd257b51857e097b9 Mon Sep 17 00:00:00 2001

From: Martin Kampas <martin.kampas@ubedi.net>

Date: Mon, 19 Oct 2020 07:22:57 +0200

Subject: [PATCH] org-colview: Fix done keywords highlighting in agenda buffers


* lisp/org-colview.el (org-agenda-columns): Populate

org-done-keywords from org-done-keywords-for-agenda or the done keywords

will use the same face as those not-done.

---

 lisp/org-colview.el | 1 +

 1 file changed, 1 insertion(+)


diff --git a/lisp/org-colview.el b/lisp/org-colview.el

index e50a4d7c8..565bdb2dd 100644

--- a/lisp/org-colview.el

+++ b/lisp/org-colview.el

@@ -1586,6 +1586,7 @@ PARAMS is a property list of parameters:

       (move-marker org-columns-begin-marker (point))

     (setq org-columns-begin-marker (point-marker)))

   (let* ((org-columns--time (float-time))

+    (org-done-keywords org-done-keywords-for-agenda)

     (fmt

       (cond

        ((bound-and-true-p org-overriding-columns-format))

--

2.28.0



--nextPart6662692.yhU5OHXL03--