From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Cc: "Martin Edström" <meedstrom91@gmail.com>
Subject: Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command
Date: Mon, 26 Feb 2024 23:37:42 +0700 [thread overview]
Message-ID: <735645dd-1ddf-4579-a6dd-2700f3e83c94@gmail.com> (raw)
In-Reply-To: <87msrncxhq.fsf@localhost>
On 26/02/2024 17:48, Ihor Radchenko wrote:
> Max Nikulin writes:
>> Something weird may be executed in the case of sufficiently complex
>> equations.
>
>> It should be more reliable to pass fragment to command stdin. It can be
>> done if %i is missed in `org-latex-to-html-convert-command'.
>
> I agree that it will be more reliable to shell-escape argument.
> However, I am concerned that escaping may break certain uses like
>
> somecommand << EOF
> %i
> EOF
>
> In the above scenario, escaping will break things.
It is unsafe to use such command. Variable expansion, etc. is performed
inside here document blocks. Try
cat << EOF
\[f(i), \text{where $i \ne 10$}\]
EOF
That is why I proposed to use stdin in the case of missed %i.
`org-latex-to-html-convert-command' should be set to something like
"latexmlc --profile=math --preload=siunitx.sty - 2>/dev/null"
this case.
> That's why I prefer to add a new replacement, not change the meaning of
> %i. We might even remove %i from the docstring, keeping support in the
> code for backwards-compatibility.
What you calls backward compatibility is actually a means to get strange
results in the case of complex math. It is better to force users to
update configuration (I hope, it actually will not be necessary) and to
ensure safe command without pitfalls related to missed parts of equations.
> (with-temp-file "/tmp/test2.html"
> (let ((org-latex-to-html-convert-command
> "latexmlc literal:%I --profile=math --preload=siunitx.sty 2>/dev/null"))
> (insert (org-format-latex-as-html "$f' = df/dx$"))))
>
> test2.html is rendered *incorrectly* as in the attached screenshot.
Looks like missed <meta charset="UTF-8"> inside <head>
> In contrast, manually providing output file as
>
> latexmlc literal:\$f\'\ =\ df/dx\$ --profile=math --preload=siunitx.sty --output /tmp/test3.html
>
> yields correct rendering.
Perhaps this time the browser just guessed file encoding. Anyway
rendering is incorrect. Gecko puts derivative into the correct place. I
have no idea if it is a fault of latexml generating incorrect MathML or
a browser which is likely a KHTML descendant.
It seems, latexml is terribly broken in Debian. With
--preload=siunitx.sty it hangs during processing of expl3-code.tex,
without this option it removes all files in /tmp.
I am still strongly against code that may cause execution of equations
as shell commands and may silently lose parts of equations.
next prev parent reply other threads:[~2024-02-26 16:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 23:10 Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Martin Edström
2024-02-18 16:06 ` Ihor Radchenko
2024-02-18 18:56 ` Martin Edström
2024-02-18 19:36 ` Martin Edström
2024-02-19 8:30 ` Ihor Radchenko
2024-02-21 14:38 ` Max Nikulin
2024-02-21 14:57 ` Martin Edström
2024-02-21 15:04 ` Martin Edström
2024-02-21 15:08 ` Martin Edström
2024-02-23 12:46 ` Ihor Radchenko
2024-02-25 10:41 ` Max Nikulin
2024-02-26 10:48 ` Ihor Radchenko
2024-02-26 16:37 ` Max Nikulin [this message]
2024-03-08 11:16 ` Ihor Radchenko
2024-03-09 15:23 ` Max Nikulin
2024-03-10 5:02 ` [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command) Max Nikulin
2024-03-31 8:27 ` Ihor Radchenko
2024-04-01 10:39 ` Max Nikulin
2024-04-01 11:23 ` Ihor Radchenko
2024-03-12 13:03 ` Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Ihor Radchenko
2024-03-13 14:27 ` Max Nikulin
2024-03-15 13:49 ` Ihor Radchenko
2024-03-18 10:50 ` Max Nikulin
2024-03-19 14:48 ` Ihor Radchenko
2024-03-19 14:49 ` Ihor Radchenko
2024-03-19 16:22 ` Max Nikulin
2024-03-19 16:27 ` Ihor Radchenko
2024-03-19 16:45 ` fixup! and git Max Nikulin
2024-03-19 16:50 ` Ihor Radchenko
2024-03-31 8:25 ` Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Ihor Radchenko
2024-04-01 10:29 ` Max Nikulin
2024-04-01 11:15 ` Ihor Radchenko
2024-03-05 12:01 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=735645dd-1ddf-4579-a6dd-2700f3e83c94@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=meedstrom91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).