From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ICpNCZmS3WChWAEAgWs5BA (envelope-from ) for ; Thu, 01 Jul 2021 12:02:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uM0VBZmS3WDcRQAA1q6Kng (envelope-from ) for ; Thu, 01 Jul 2021 10:02:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 664AA2782D for ; Thu, 1 Jul 2021 12:02:00 +0200 (CEST) Received: from localhost ([::1]:59238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lytWA-0000yr-1B for larch@yhetil.org; Thu, 01 Jul 2021 06:01:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lynt2-0004SP-VP for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 00:01:13 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:26762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lynt0-0007Mi-9r for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 00:01:12 -0400 Date: Thu, 01 Jul 2021 04:01:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625112066; bh=s+SB4p0v4wbdS9N6agjgdSzyZn+J1e9XjUfz8bg4N9s=; h=Date:To:From:Reply-To:Subject:From; b=uti0OPJiJyHGzB16kTc+KJxmeUOYVzks04xFsM5ryUyo7eKWYAQS1XjmjOKldwClW gJNPCkFzfP0dRQResK8J8wgmdjQT9+yxdGXkvcFNqrrBsHBDFdNw7A+LKAgvG8pV/5 iuU6LC+75Ex3yaBVIAd6gkJaaf/djH8XekUh+LwE= To: Org-mode Org-Mode From: Jacopo De Simoi Subject: [PATCH} Do not throw error when parameter of :tangle is not a string Message-ID: <7267271.EvYhyI6sBW@bl4ckspoons> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_DgcmiQQVt78oXjN3yYqlMDIZp1kWPM3JE3lck8s3MU" Received-SPF: pass client-ip=185.70.40.133; envelope-from=jacopods@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 01 Jul 2021 06:00:27 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jacopo De Simoi Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625133720; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=s+SB4p0v4wbdS9N6agjgdSzyZn+J1e9XjUfz8bg4N9s=; b=seRmP3Oi8gwDjkHPdE0VCJpGjUq1EThmxYA1vhBXAs3oe9c2p4PWcwGqKe8lRBrh9jy5Wh 0FjqW7wbGcYrH8QtX1Q800BAoew/gGzS4ira7L+vkcRwOYyDAMaVuV5oLqHcLDGefgteA/ uVrMfGbDjJUv2GiPX8QrJXJ1PyBU1/Ala062mjOcuTYgfb2IbN7hTvTVXEx/5z7fEpQbcm qnT9VEyT/E2oiZLEvqA4hsfE7Ixx1vsYlD5rvqNlZFRIorp9VU3VoUidQv1BNQsfyDFzQh rpZj2c9EmSeHyVO5xZ26NthimbUbiLZKP1XI2iM7VJzzBow1/Q5CUCzK+8WaLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625133720; a=rsa-sha256; cv=none; b=TZwBHF3Hwswa5bmhD5lqNdMsqFid79YNLxtU1lScJuJkp4RUXV9RJXXs9vTa31SHB7TCZO aPutTuVwbBpuz0AtX0ob19eEavgU15B8+b3gdQrwHmmoSIouvVJSVIlP7AQXG4XwcGKb9o 4MH3dQhiHx9Ke2fXcFw7wqDajnW/0NPllzYrqYdn46mSTP9X+WuLezcZ67pQYVKzL4CDQz rgRtI4dOldiXijC9Sgu48/83MMDkaBu/XU3Wsaz39sTwoxDi+eV2yVDi0WoiIonQxkG/b7 XtDmjaTTSlY94CfZpIbGH+fAine+HskpL9bZbcME+3A3WqUqSyYdIePyDI/ILQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=uti0OPJi; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.52 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=uti0OPJi; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 664AA2782D X-Spam-Score: -3.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: +i3+9rQWg4xS This is a multi-part message in MIME format. --b1_DgcmiQQVt78oXjN3yYqlMDIZp1kWPM3JE3lck8s3MU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dear All, in the current master branch, if the parameter :tangle of a src block is n= ot a string, tangling fails by throwing an error when calling `file-name- directory' This patch checks if the parameter is a string before calling `file-name-directory'. This makes construct such as :tangle (when condition-applies "filename") wo= rk again (as they did a few versions ago=E2=80=A6) Thanks for your time Best Jacopo --b1_DgcmiQQVt78oXjN3yYqlMDIZp1kWPM3JE3lck8s3MU Content-Type: text/x-patch; name=0001-ob-tangle.el-Handle-non-string-arguments-more-gracef.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-ob-tangle.el-Handle-non-string-arguments-more-gracef.patch RnJvbSBmMDhlY2RiNzllYzcxZWNjOTRmZTAwNjA0M2JkOGVhY2M4YWM0MWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogSmFjb3BvIERlIFNpbW9pIDxqYWNvcG9kc0Bwcm90b25tYWls LmNvbT4NCkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMTU6NDI6MjkgLTA0MDANClN1YmplY3Q6IFtQ QVRDSCAxLzJdIG9iLXRhbmdsZS5lbDogSGFuZGxlIG5vbi1zdHJpbmcgYXJndW1lbnRzIG1vcmUg Z3JhY2VmdWxsdQ0KDQoqIGxpc3Avb2ItdGFuZ2xlLmVsIChvcmctYmFiZWwtdGFuZ2xlLXNpbmds ZS1ibG9jayk6IElmIHRoZQ0KICBhcmd1bWVudCB0byA6dGFuZ2xlIGlzIG5pbCAoZS5nLiB3aGVu IHBhcnNpbmcgY29uZGl0aW9uYWwNCiAgdGFuZ2xpbmcgc3VjaCBhcyAod2hlbiBjb25kaXRpb24g InllcyIpIHRoZSBjdXJyZW50IGNvZGUNCiAgdGhyb3dzIGFuIGVycm9yIGluIGBmaWxlLW5hbWUt ZGlyZWN0b3J5Jy4gIFRoaXMgY29tbWl0DQogIGNoZWNrcyBpZiB0aGUgYXJndW1lbnQgaXMgYSBz dHJpbmcgYmVmb3JlIGNhbGxpbmcgdGhlIGZ1bg0KDQpUSU5ZQ0hBTkdFDQotLS0NCiBsaXNwL29i LXRhbmdsZS5lbCB8IDkgKysrKystLS0tDQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3Avb2ItdGFuZ2xlLmVsIGIvbGlz cC9vYi10YW5nbGUuZWwNCmluZGV4IDU2Mjc3NmFlOC4uMDIzNzlkNDRlIDEwMDY0NA0KLS0tIGEv bGlzcC9vYi10YW5nbGUuZWwNCisrKyBiL2xpc3Avb2ItdGFuZ2xlLmVsDQpAQCAtNDY5LDYgKzQ2 OSw3IEBAIG5vbi1uaWwsIHJldHVybiB0aGUgZnVsbCBhc3NvY2lhdGlvbiBsaXN0IHRvIGJlIHVz ZWQgYnkNCiAJCQkgKG1hdGNoLWVuZCAwKQ0KIAkJICAgICAgIChwb2ludC1taW4pKSkpDQogCSAg ICAgIChwb2ludCkpKSkpDQorICAgICAgICAgKHNyYy10ZmlsZSAoY2RyIChhc3NxIDp0YW5nbGUg cGFyYW1zKSkpDQogCSAocmVzdWx0DQogCSAgKGxpc3Qgc3RhcnQtbGluZQ0KIAkJKGlmIG9yZy1i YWJlbC10YW5nbGUtdXNlLXJlbGF0aXZlLWZpbGUtbGlua3MNCkBAIC00NzYsMTEgKzQ3NywxMiBA QCBub24tbmlsLCByZXR1cm4gdGhlIGZ1bGwgYXNzb2NpYXRpb24gbGlzdCB0byBiZSB1c2VkIGJ5 DQogCQkgIGZpbGUpDQogCQkoaWYgKGFuZCBvcmctYmFiZWwtdGFuZ2xlLXVzZS1yZWxhdGl2ZS1m aWxlLWxpbmtzDQogCQkJIChzdHJpbmctbWF0Y2ggb3JnLWxpbmstdHlwZXMtcmUgbGluaykNCi0J CQkgKHN0cmluZz0gKG1hdGNoLXN0cmluZyAxIGxpbmspICJmaWxlIikpDQorCQkJIChzdHJpbmc9 IChtYXRjaC1zdHJpbmcgMSBsaW5rKSAiZmlsZSIpDQorICAgICAgICAgICAgICAgICAgICAgICAg IChzdHJpbmdwIHNyYy10ZmlsZSkpDQogCQkgICAgKGNvbmNhdCAiZmlsZToiDQogCQkJICAgIChm aWxlLXJlbGF0aXZlLW5hbWUgKHN1YnN0cmluZyBsaW5rIChtYXRjaC1lbmQgMCkpDQogCQkJCQkJ KGZpbGUtbmFtZS1kaXJlY3RvcnkNCi0JCQkJCQkgKGNkciAoYXNzcSA6dGFuZ2xlIHBhcmFtcykp KSkpDQorCQkJCQkJIHNyYy10ZmlsZSkpKQ0KIAkJICBsaW5rKQ0KIAkJc291cmNlLW5hbWUNCiAJ CXBhcmFtcw0KQEAgLTQ4OSw4ICs0OTEsNyBAQCBub24tbmlsLCByZXR1cm4gdGhlIGZ1bGwgYXNz b2NpYXRpb24gbGlzdCB0byBiZSB1c2VkIGJ5DQogCQkgIChvcmctdHJpbSAob3JnLXJlbW92ZS1p bmRlbnRhdGlvbiBib2R5KSkpDQogCQljb21tZW50KSkpDQogICAgIChpZiBvbmx5LXRoaXMtYmxv Y2sNCi0gICAgICAgIChsZXQqICgoc3JjLXRmaWxlIChjZHIgKGFzc3EgOnRhbmdsZSAobnRoIDQg cmVzdWx0KSkpKQ0KLSAgICAgICAgICAgICAgIChmaWxlLW5hbWUgKG9yZy1iYWJlbC1lZmZlY3Rp dmUtdGFuZ2xlZC1maWxlbmFtZQ0KKyAgICAgICAgKGxldCogKChmaWxlLW5hbWUgKG9yZy1iYWJl bC1lZmZlY3RpdmUtdGFuZ2xlZC1maWxlbmFtZQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAg IChudGggMSByZXN1bHQpIHNyYy1sYW5nIHNyYy10ZmlsZSkpKQ0KICAgICAgICAgICAobGlzdCAo Y29ucyBmaWxlLW5hbWUgKGxpc3QgKGNvbnMgc3JjLWxhbmcgcmVzdWx0KSkpKSkNCiAgICAgICBy ZXN1bHQpKSkNCi0tIA0KMi4zMS4xDQoNCg== --b1_DgcmiQQVt78oXjN3yYqlMDIZp1kWPM3JE3lck8s3MU Content-Type: application/pgp-signature; name=attachment.asc Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=attachment.asc LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NCg0KaVFFekJBQUJDQUFkRmlFRVc1cXU2aWtQ VHNub0lyQlNzUUFqc0hYek9pTUZBbURkUGV3QUNna1FzUUFqc0hYeg0KT2lQdTJBZitNcWZNVWRh R0RtL2FOdTlPSU5IOE1mRlB6aTBncUJwZUhQRXE3bjd4bGtYTUpDNmZidUNvM1ZWQQ0KdFliaDZs b2RPdmxXODlGRjhidzRkOVF6SGkrNi94VzBMTlJZRmRZcDNyTjlaZDBCUUx1YlVjUjB3RmRKb2dm VA0KR1hveFhzV1NpYTBYRXlvKzRvOGUyQklBcTAyNVF0NWcyNjF1TVJyOEQvKzd0Vy9WZWZXZmJD cVFFVkVpVElxZA0KczZ0d292cE1MNzBLSldqZEc1T3pjQzhlclhvQkZQOWh4NENlZ3BTREdhaGZz Qm1NYUUyR29WV3E3UTBnSEFNTQ0KWWN4bTBIaFVyTjVkSkFwY0FhMEJyOVdlS1ZvUDNrZlowdXYz dzNzNXRsMkJzMjN1aGVvT0duOEgrcXYzb0R2VQ0Kd3IxN0pnQ1NBbVUxd2xQY2RqWE4vcWdzSmNz OVdBPT0NCj1nWm1kDQotLS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0NCg== --b1_DgcmiQQVt78oXjN3yYqlMDIZp1kWPM3JE3lck8s3MU--