From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SM4vAAziMWeEOgAA62LTzQ:P1 (envelope-from ) for ; Mon, 11 Nov 2024 10:53:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id SM4vAAziMWeEOgAA62LTzQ (envelope-from ) for ; Mon, 11 Nov 2024 11:53:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=7d.nz header.s=20240212 header.b=mbmVLEOv; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=7d.nz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731322379; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=kcueVhqoqHI+1muzK697yMF63Cd0CNiUbErYzKHp6gI=; b=bzhAyQvKdyZYSwnIMSCgmJYvKcZoGDvgLOdNwiygcgQUPBlnH1+9jnkBrmGnNuiyhY8k9f jlX0PftJrbxQaAoMRkKFfFovVCLIFx1962oiAHkJpVRTRD4i6jjvYVTaCluK6/8xVaeU7E DRnv8xuSzOL0czOrGpTeGRZ8mw3dItTgL2wD0dbTfOtvQF6AItBr8o0hA8oH9SCSilBEyQ nTs5+jj7qUvyAh2Br+kJr4UuU30oJ10SNdDF2N/ZEI4Z3Z39mcZ1JIO9CCkTK2oXx969iV MIlo+R94l+d80+8YlB4mtJtdMv1jGLowHYHcQrUOLQpFG+fE7rkaRpd5GS8I0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731322379; a=rsa-sha256; cv=none; b=bh1HWas48SngSfahyNVmTuk94ziv5rDr7U9sfPpCDS3rI4E+wXq81ddxF4h9exDQMnO9IS M/TqF2/B/y2WitSiG4sl3o0GDmh+BYN8neHgdiDTAGGaXjcC3NoLxKQIAfTGCp3PyixAFu HKZKft8zXKzC9SO9dm5EChCiV9N0ef1Xe3obHlFpFAgnSW8CjaE8NVdwLlN36g6QAwKTat 169CT4NEVH94me4XjiPY7f6+ds8jgNnsELRpXbt0y5wajIql663dSILdecBfJHq8Ea4BDc PfWvJ8cIa01aqSt0nilB0W0rbJ+JY6QF2jH0enwnDA8Lk4GxbBbIPqsqYVgHpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=7d.nz header.s=20240212 header.b=mbmVLEOv; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=7d.nz Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57A8B383E for ; Mon, 11 Nov 2024 11:52:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAS1p-0001IJ-I6; Mon, 11 Nov 2024 05:52:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAS1m-0001Hu-LQ for emacs-orgmode@gnu.org; Mon, 11 Nov 2024 05:52:14 -0500 Received: from smtp-8fad.mail.infomaniak.ch ([83.166.143.173]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAS1j-0008UG-He for emacs-orgmode@gnu.org; Mon, 11 Nov 2024 05:52:14 -0500 Received: from smtp-4-0000.mail.infomaniak.ch (smtp-4-0000.mail.infomaniak.ch [10.7.10.107]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Xn5vw05qQzdg4; Mon, 11 Nov 2024 11:51:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=7d.nz; s=20240212; t=1731322315; bh=kcueVhqoqHI+1muzK697yMF63Cd0CNiUbErYzKHp6gI=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=mbmVLEOvN7WYmWQCtI4cYGkPPM1S2x6m9Dl0EMX1UwZu6uUMo3O2NdzwXfTGC4Vxa 4CsufKn/F0+XvrLWx7g82a1eYupxsJyEPZjPx9hDt3WPq/P9lEBNzmMmrsAUyDHEd9 j2ANs5YpCv55yhzA2Se9usV0V2GlaR61YLlSU5uJMDRyZVNieFB7Xwu8zbTqYyDVUQ WNPy8or2FiWg3xgawevERPDSQtFDGSGsnubGZAmvMDSCgR+faiPBfgQFECO5UivVsg /CkH/Y2+FLE/dkgtSaZQdPqfpu4EdfSHfNjDfYXclbPwr8e96xdt8DhoaizD80Vq8I f8pfefngl7qKA== Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4Xn5vv3nbzzvxk; Mon, 11 Nov 2024 11:51:55 +0100 (CET) Message-ID: <6daf618b-ef67-497b-aa1c-aaa1f4804143@7d.nz> Date: Mon, 11 Nov 2024 11:51:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Phil Estival Subject: Re: patch : ob-sql :session To: Ihor Radchenko Cc: Org Mode List References: <1a69c5fb-4069-45c8-b37b-4d54ef88b92d@alphapapa.net> <3a694658-9184-4c45-ac17-6e6083a21517@7d.nz> <87msizq7g3.fsf@localhost> <877c9cfowi.fsf@localhost> Content-Language: fr, fr-FR, en-US In-Reply-To: <877c9cfowi.fsf@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha Received-SPF: pass client-ip=83.166.143.173; envelope-from=pe@7d.nz; helo=smtp-8fad.mail.infomaniak.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.14 X-Spam-Score: -1.14 X-Migadu-Queue-Id: 57A8B383E X-Migadu-Scanner: mx13.migadu.com X-TUID: B2mW0vW+eUGh * [2024-11-09 15:43] Ihor Radchenko: > Phil Estival writes: > >>> Have you considered integrating it into ob-sql itself? >>> If not, what are the obstacles? >>> >> >> Hello Ihor, >> >> yes I have. It grows ob-sql by approximately 300 lines. >> There are rooms for improvements. >> https://github.com/flintforge/ob-sql-session/blob/main/ob-sql.el >> > Thanks for the update! > I will be looking towards your improvements to be merged upstream. > Feel free to ask me anything if you need any help. > I will keep running ob-sql with :session in the next days. This work configuration should help to detect if there is an anomaly. Shall I submit a patch? Since many lines are changed due to proper indentation, docstrings, untabification and a few lateral improvements, I was wondering if such a patch has to be gradual and minimize sudden changes. Also I'm trying to run the tests with : make BTEST_RE='ob-sql.*' test-dirty but they get skipped due to a missing dependency, and I don't know in which direction to look for from there. Below is what the command returns. Any idea ? 27 files scanned, 13 files contains IDs, and 54 IDs found. 0 source block added to Library of Babel Local variables list is not properly terminated selected tests: ob-sql.* Running 2 tests (2024-11-11 11:17:40+0100, selector ‘"ob-sql.*"’) skipped 1/2 *org-missing-dependency*/test-ob-sql (0.000139 sec) skipped 2/2 *org-missing-dependency*/test-ob-sqlite (0.000098 sec) Ran 2 tests, 0 results as expected, 0 unexpected, 2 skipped (2024-11-11 11:17:40+0100, 0.000470 sec) ? -- Phil Estival