emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sheng Yang" <styang@fastmail.com>
To: "Protesilaos Stavrou" <info@protesilaos.com>,
	"Ihor Radchenko" <yantar92@gmail.com>
Cc: Bastien <bzg@gnu.org>, Diego Zamboni <diego@zzamboni.org>,
	Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Adaptive Org faces in headings?
Date: Sat, 19 Sep 2020 22:24:10 -0500	[thread overview]
Message-ID: <6c38aabf-6921-4843-9302-db080b2de2e5@www.fastmail.com> (raw)
In-Reply-To: <877dsro1ho.fsf@protesilaos.com>

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

Thanks for the patch!
I noticed the patch also works for org-link, which had been a headache for me.

On Fri, Sep 18, 2020, at 04:52, Protesilaos Stavrou wrote:
> Ihor Radchenko <yantar92@gmail.com> [2020-09-17, 16:25 +0800]:
> 
> > The attached patch seems to fix the issue.
> > Can anyone test?

I also tested, with the following org file. Works well with one exception: the underline for org-link, which remains the color of itself. The reason is that face org-link inherits face link, which has :underline t in its setting. Therefore, it should be the expected behavior.
> * test ~code~ =verb= [[link]]
>   #+begin_src emacs-lisp
> (set-face-attribute 'org-level-1 nil :height 3.0 :weight 'normal)
> (set-face-attribute 'org-level-1 nil :weight 'bold)
> (set-face-attribute 'org-level-1 nil :background "white")
> (set-face-attribute 'org-level-1 nil :overline "yellow")
> (set-face-attribute 'org-level-1 nil :underline "red")
>   #+end_src


Sheng Yang(杨圣), PhD student
Computer Science Department
University of Maryland, College Park
E-mail: styang@fastmail.com
E-mail (old but still used): yangsheng6810@gmail.com


[-- Attachment #2: Type: text/html, Size: 1925 bytes --]

  reply	other threads:[~2020-09-20  3:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26  5:16 Adaptive Org faces in headings? Protesilaos Stavrou
2020-04-26  7:42 ` Ihor Radchenko
2020-09-05 14:47 ` Bastien
2020-09-06 19:58   ` Protesilaos Stavrou
2020-09-05 21:39 ` Diego Zamboni
2020-09-07  4:08   ` Protesilaos Stavrou
2020-09-09  8:49     ` Bastien
2020-09-09  9:11       ` TEC
2020-09-09 14:44         ` Bastien
2020-09-12  7:33       ` Protesilaos Stavrou
2020-09-17  8:25         ` [PATCH] " Ihor Radchenko
2020-09-18  9:52           ` Protesilaos Stavrou
2020-09-20  3:24             ` Sheng Yang [this message]
2020-10-27 18:30             ` Rob Davenport
2020-10-28 15:37               ` Rob Davenport
2020-09-21 16:05           ` Mikhail Skorzhinskii
2020-09-23 12:25           ` Bastien
2020-09-23 12:28             ` Protesilaos Stavrou
2020-09-26  6:31             ` Bastien
2020-10-05 10:11               ` Protesilaos Stavrou
2020-10-07  4:20                 ` Kyle Meyer
2020-10-07  5:29                   ` Protesilaos Stavrou
2020-10-08  3:37                     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c38aabf-6921-4843-9302-db080b2de2e5@www.fastmail.com \
    --to=styang@fastmail.com \
    --cc=bzg@gnu.org \
    --cc=diego@zzamboni.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=info@protesilaos.com \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).