From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH 2/2] Fix broken CUSTOM_ID links Date: Wed, 17 Nov 2010 14:26:08 +0100 Message-ID: <69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com> References: <81mxpnwtah.fsf@gmail.com> <43EFAC24-FD29-4565-AB08-0C6F2AF6CBA5@gmail.com> <81oca0rl2h.fsf_-_@gmail.com> <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=44877 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIi1d-00040s-6w for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 08:26:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIi1b-0005zY-SA for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 08:26:13 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:34307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIi1b-0005zO-I1 for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 08:26:11 -0500 Received: by wwc33 with SMTP id 33so2046570wwc.30 for ; Wed, 17 Nov 2010 05:26:10 -0800 (PST) In-Reply-To: <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org, Jambunathan K Hi Jambunathan, did you already react on this message? I cannot seem to find your reply. Thanks! - Carsten On Nov 12, 2010, at 4:50 PM, Carsten Dominik wrote: > Hi Jambunata, > > this looks good, However, I would like you to make a change to the > patch more more clarity. > > Could you please write > > (or preferred target) > > instead of > > remove > > as the ID to be inserted? Even though these are the same, the first > version is a lot clearer. > > With this change, I will accept the patch. > > Thanks! > > - Carsten > > On Nov 8, 2010, at 7:39 AM, Jambunathan K wrote: > >> >> Carsten >> >>> On Nov 5, 2010, at 6:53 PM, Jambunathan K wrote: >>> >>>> >>>> Note the 'H:1' in options line. Export this to HTML. Note that >>>> CUSTOMID >>>> link is broken. A snippet of relevant HTML section is attached >>>> below. >>>> >>>> Change 'H:1' to 'H:3' note that there is no more brokenness. >>>> >>>> Possible root cause: When headlines are turned to list 'extra- >>>> targets' >>>> are not identified correctly. >>> >>> That is correct - Org does not assign IDs or names to list items, >>> so it has no place to link to. This could probably be fixed - >>> anyone >>> would >>> like to fix this? >>> >> >> I am attaching a patch. Hope it does the right thing. >> >> --- before.html 2010-11-08 19:01:13.796875000 +0530 >> +++ after.html 2010-11-08 19:00:57.859375000 +0530 >> @@ -7,7 +7,7 @@ >> tmp >> >> >> - >> + >> >> >> >> @@ -101,7 +101,7 @@ >> >> >>
    >> -
  • > a>Target with CUSTOMID
    >> +
  • > a>Target with CUSTOMID
    >> >>

    >> One >> @@ -200,7 +200,7 @@ >>

    Author: Jambunathan K >> > href >> ="mailto:kjambunathan@gmail.com"><kjambunathan@gmail.com> >>

    >> -

    Date: 2010-11-08 18:57:46

    >> +

    Date: 2010-11-08 18:56:05

    >>

    HTML generated by org-mode 7.3 in emacs 23

    >> >> >> <0002-Fix-broken-CUSTOM_ID-links-to-outline-levels-exporte.patch> >>> - Carsten >>> >>>> >>>> (This bug is unrelated to any of the previous internal link bugs >>>> that I >>>> have reported) >>>> >>>> # Input file >>>> >>>> #+OPTIONS: H:1 >>>> >>>> * Links >>>> ** Targets >>>> >>>> *** Fuzzy Target >>>> >>>> *** Target with CUSTOMID >>>> :PROPERTIES: >>>> :CUSTOM_ID: aabbccddeeff >>>> :END: >>>> >>>> *** Dedicated Target >>>> # <> >>>> >>>> *** <<>> >>>> >>>> ** References >>>> >>>> *** References to Fuzzy Target >>>> This is a link to [[Fuzzy Target]]. >>>> >>>> *** References to CUSTOMID links >>>> This link to [[#aabbccddeeff][CUSTOMID Target]] is broken. >>>> >>>> *** References to Dedicated Target >>>> There is a link to nodesc [[Dedicated Target]] here. There is a >>>> link >>>> to [[Dedicated%20Target][Jump to Dedicated Target]] here. >>>> >>>> *** References to Radioed Links >>>> This section has references to Radioed Target. One more reference >>>> to Radioed Target. >>>> >>>> >>>> >>>> #+begin_src html >>>> >>>>
      >>>>
    • >>>> >>>> >>>> Target with CUSTOMID >>>>
      >>>>
      • >>>>
    >>>> >>>> >>>> >>>> #+end_src >>>> >>>> >>>> Jambunathan K. >>>> >>>> _______________________________________________ >>>> Emacs-orgmode mailing list >>>> Please use `Reply All' to send replies to the list. >>>> Emacs-orgmode@gnu.org >>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > - Carsten