From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Skim.app support for org-mac-link-grabber.el Date: Mon, 13 May 2013 12:54:24 +0200 Message-ID: <69C653ED-F55B-4798-A653-074CCBB12ABD@gmail.com> References: <171D50FA-314D-4233-9F7E-AD07D8B1B902@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_37727D77-6E9D-47B8-9A98-F01957D89320" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbqOi-0006RP-KT for emacs-orgmode@gnu.org; Mon, 13 May 2013 06:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbqOg-0000Tc-Sn for emacs-orgmode@gnu.org; Mon, 13 May 2013 06:54:28 -0400 Received: from ezel.ic.uva.nl ([146.50.108.158]:51940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbqOg-0000TF-H0 for emacs-orgmode@gnu.org; Mon, 13 May 2013 06:54:26 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Daniel F Cc: "emacs-orgmode@gnu.org Mode" --Apple-Mail=_37727D77-6E9D-47B8-9A98-F01957D89320 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On 13 mei 2013, at 11:53, Daniel F wrote: > Hi Carsten, Ivan. >=20 > Thanks for the feedback. The issue that Ivan mentioned does look = important and I'll try to fix it asap and incorporate the check. > I'll also look into the rehilighting thing, I am not sure if that's = possible. I guess it also would be nice to scroll not just to the right = page, but also to the right line in the text. >=20 > As for the "as-" prefix I just assumed that this is legit because the = package was already present in the org-mode. Yes, I see that this is also done in org-mac-message.el. Hmmmm. - Carsten >=20 > Cheers. >=20 > - Dan >=20 >=20 > On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik = wrote: > Hi Daniil, >=20 > I like this a lot and would like to take the patch after you have = taken Ivans feedback, and maybe more feedback if you get any. >=20 > I would like it even more if following the link would rehighlight the = selected text. Is there any way to achieve this? >=20 > I have another question, this would maybe be for the original author, = Anthony Lander? I see that there are functions with prefixes that are = not "org-". This is dangerous because there might be packages around = that use that name space. I also think it violates coding rules in = Emacs. I think this should be changed - unless you know of a convention = that all functions dealing with applescripts are supposed to have an = "as-" prefix. >=20 > I can fix this - but I wanted your feedback first. >=20 > Thanks. >=20 > - Carsten >=20 > On 12 mei 2013, at 20:29, Daniil Frumin wrote: >=20 > > Hi, all! > > > > I use org-mac-link-grabber.el = almost = every day. However, it lacks support for an app that I'd like to use = together with org-mode. > > > > Skim.app is a light and fast PDF reader for Mac OS X with a = note-taking ability. I wrote a little patch for org-mac-link-grabber.el = to support grabbing links to documents. > > > > What it does: > > > > * Grabs not just the link to file, but a page > > > > * Inserts the selected text as a description, if present. Otherwise > > inserts ", p. " > > > > * The shortcut is set to [S] > > > > * Defines a new "skim" link type > > > > It would be interesting to also add some support for importing notes = from Skim to org. > > > > Since Skim.app is not present in clean OS X installs, by default = support for grabbing links from it is disabled. You can enable it by = customizing group `org-mac-link-grabber'. > > > > So, maybe it's possible to get this patch into the tree? It's my = first time hacking on org (or even any major elisp extension), so it's = probably that I've messed up somewhere with a commit format or whatnot. > > > > Cheers. > > > > -- Daniil Frumin > > <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch> >=20 >=20 >=20 >=20 > --=20 > Sincerely yours, > -- Daniil --Apple-Mail=_37727D77-6E9D-47B8-9A98-F01957D89320 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=iso-8859-1
On 13 mei 2013, at 11:53, Daniel F <difrumin@gmail.com> wrote:

Hi Carsten, Ivan.

Thanks for the feedback. The issue that Ivan mentioned does look important and I'll try to fix it asap and incorporate the check.
I'll also look into the rehilighting thing, I am not sure if that's possible. I guess it also would be nice to scroll not just to the right page, but also to the right line in the text.

As for the "as-" prefix I just assumed that this is legit because the package was already present in the org-mode.

Yes, I see that this is also done in org-mac-message.el. Hmmmm.

- Carsten


Cheers.

- Dan


On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik <carsten.dominik@gmail.com> wrote:
Hi Daniil,

I like this a lot and would like to take the patch after you have taken Ivans feedback, and maybe more feedback if you get any.

I would like it even more if following the link would rehighlight the selected text.  Is there any way to achieve this?

I have another question, this would maybe be for the original author, Anthony Lander?  I see that there are functions with prefixes that are not "org-".  This is dangerous because there might be packages around that use that name space.  I also think it violates coding rules in Emacs.  I think this should be changed - unless you know of a convention that all functions dealing with applescripts are supposed to have an "as-" prefix.

I can fix this - but I wanted your feedback first.

Thanks.

- Carsten

On 12 mei 2013, at 20:29, Daniil Frumin <difrumin@gmail.com> wrote:

> Hi, all!
>
> I use org-mac-link-grabber.el <http://orgmode.org/worg/org-contrib/org-mac-link-grabber.html> almost every day. However, it lacks support for an app that I'd like to use together with org-mode.
>
> Skim.app is a light and fast PDF reader for Mac OS X with a note-taking ability. I wrote a little patch for org-mac-link-grabber.el to support grabbing links to documents.
>
> What it does:
>
> * Grabs not just the link to file, but a page
>
> * Inserts the selected text as a description, if present. Otherwise
>  inserts "<filename>, p. <page #>"
>
> * The shortcut is set to [S]
>
> * Defines a new "skim" link type
>
> It would be interesting to also add some support for importing notes from Skim to org.
>
> Since Skim.app is not present in clean OS X installs, by default support for grabbing links from it is disabled. You can enable it by customizing group `org-mac-link-grabber'.
>
> So, maybe it's possible to get this patch into the tree? It's my first time hacking on org (or even any major elisp extension), so it's probably that I've messed up somewhere with a commit format or whatnot.
>
> Cheers.
>
> -- Daniil Frumin
> <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch>




--
Sincerely yours,
-- Daniil

--Apple-Mail=_37727D77-6E9D-47B8-9A98-F01957D89320--