From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH: RESUBMITTED] Fix broken CUSTOM_ID links Date: Sun, 21 Nov 2010 09:45:30 +0100 Message-ID: <685ADC1C-BC79-4F05-82AE-27BFD8409AF0@gmail.com> References: <81mxpnwtah.fsf@gmail.com> <43EFAC24-FD29-4565-AB08-0C6F2AF6CBA5@gmail.com> <81oca0rl2h.fsf_-_@gmail.com> <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com> <69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com> <814obgnf07.fsf@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=34927 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PK5YH-0001dH-5i for emacs-orgmode@gnu.org; Sun, 21 Nov 2010 03:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PK5YF-00061Y-Ve for emacs-orgmode@gnu.org; Sun, 21 Nov 2010 03:45:37 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:50839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PK5YF-00061Q-JE for emacs-orgmode@gnu.org; Sun, 21 Nov 2010 03:45:35 -0500 Received: by ewy25 with SMTP id 25so3437163ewy.0 for ; Sun, 21 Nov 2010 00:45:34 -0800 (PST) In-Reply-To: <814obgnf07.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: emacs-orgmode@gnu.org Applied, thanks! - Carsten On Nov 17, 2010, at 4:22 PM, Jambunathan K wrote: > > Carsten > >>> this looks good, However, I would like you to make a change to the >>> patch more more clarity. >>> >>> Could you please write >>> >>> (or preferred target) >>> >>> instead of >>> >>> remove >>> >>> as the ID to be inserted? Even though these are the same, the first >>> version is a lot clearer. >>> >>> With this change, I will accept the patch. > > My bad ... Ignore my previous mail. I accidentally attached the older > version that was lurking in my work area. > > Here is the newer version. > > I have made the modifications requested by you. Reproducing the > original > report for the sake of record. > > Jambunathan K. > > > > # Bug Description: Note the 'H:1' option. Search for 'broken' in the > # the below org file. > > #+OPTIONS: H:1 > > * Links > ** Targets > > *** Fuzzy Target > > One > > Two > > Three > > Four > > Five > > > *** Target with CUSTOMID > :PROPERTIES: > :CUSTOM_ID: aabbccddeeff > :END: > > One > > Two > > Three > > Four > > Five > > > *** Dedicated Target > # <> > > One > > Two > > Three > > Four > > Five > > > *** <<>> > > One > > Two > > Three > > Four > > Five > > ** References > > *** References to Fuzzy Target > This is a link to [[Fuzzy Target]]. > > *** References to CUSTOMID links > This link to [[#aabbccddeeff][CUSTOMID Target]] is broken. > > *** References to Dedicated Target > There is a link to nodesc [[Dedicated Target]] here. There is a > link > to [[Dedicated%20Target][Jump to Dedicated Target]] here. > > *** References to Radioed Links > This section has references to Radioed Target. One more reference > to Radioed Target. > > Verification: > > bash-3.2$ diff -pub customid-before.html customid-after.html > --- customid-before.html 2010-11-17 20:36:20.140625000 +0530 > +++ customid-after.html 2010-11-17 20:39:45.234375000 +0530 > @@ -1,3 +1,4 @@ > + > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> > @@ -6,7 +7,7 @@ > customid > > > - > + > > > > @@ -100,7 +101,7 @@ > > >