From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <nicholas.dokos@hp.com>
Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner
 tags
Date: Fri, 16 Mar 2012 10:25:36 -0400
Message-ID: <6857.1331907936@alphaville>
References: <ilya_shl@alum.mit.edu>
	<CACfYvRY6HZYde9gmQTuVefOh8RObGzOZ_DY+HjSOPWTLX9oPyA@mail.gmail.com>
	<3953.1331867583@alphaville>
	<CACfYvRZ+VgR16kzZoO+qr2FC3XE8prPnLFfEnS-6N+QafHXHLA@mail.gmail.com>
	<CACfYvRaye23xchbQSUtJVkpZf7xPink5mXpcNrHiXbHQ1bKP3w@mail.gmail.com>
	<20695543-EDFE-417B-9EF6-63C54EC086D7@gmail.com>
Reply-To: nicholas.dokos@hp.com
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:51950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S8Y6E-0006V8-5R
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:25:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S8Y68-0001ES-QJ
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:25:45 -0400
Received: from g4t0015.houston.hp.com ([15.201.24.18]:41739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S8Y68-0001EF-Jh
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:25:40 -0400
In-Reply-To: Message from Carsten Dominik <carsten.dominik@gmail.com> of "Fri,
	16 Mar 2012 11:35:47 BST."
	<20695543-EDFE-417B-9EF6-63C54EC086D7@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Ilya Shlyakhter <ilya_shl@alum.mit.edu>, emacs-orgmode <emacs-orgmode@gnu.org>, nicholas.dokos@hp.com

Carsten Dominik <carsten.dominik@gmail.com> wrote:

> Hi Ilya, hi Nick,
> 
> thanks for looking into this.  I am amazed by the deep
> understanding of Org's internals that shows in this
> thread.
> 

On Ilya's part, certainly - for my part, I have only the vaguest clue
about what Ilya did - I just saw a possible red flag. I still have not
looked into his patches, but now, thanks to you, I don't have to :-)
I can just enjoy the speedup!

Nick

> Both patches seem to be OK as far as I can see and
> can be applied without adverse effects.
> The patch for org-clock.el will at most achieve a factor
> of two (because org-get-tags-at is called anyway), but
> indeed, the patch in org.el can potentially have even
> more significant effects, when properties are tested
> in the matcher.
> 
> Cheers and thanks!
> 
> - Carsten