From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [dev] org-indent-mode patch Date: Mon, 14 Mar 2011 08:51:27 +0100 Message-ID: <67BE727C-BFCE-4862-9DCC-AFA4201F3DA2@gmail.com> References: <87ipvnng95.fsf@gmail.com> Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=41467 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pz34Z-0006zL-HV for emacs-orgmode@gnu.org; Mon, 14 Mar 2011 04:24:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pz34X-0001D7-Gn for emacs-orgmode@gnu.org; Mon, 14 Mar 2011 04:24:14 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:34062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pz34X-0001Cq-BS for emacs-orgmode@gnu.org; Mon, 14 Mar 2011 04:24:13 -0400 Received: by eyh6 with SMTP id 6so1530034eyh.0 for ; Mon, 14 Mar 2011 01:24:12 -0700 (PDT) In-Reply-To: <87ipvnng95.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Cc: Org Mode List Hi Nicolas, On 13.3.2011, at 17:21, Nicolas wrote: > Hello, > > I'd like to submit the following org-indent-mode patch for testing. > > git://github.com/ngz/org-mode-lists.git indent-patch-no-timer > > It implements two things: > > 1. It indents correctly text when using visual-line-mode; > 2. It removes the idle timer previous implementation was using, which > means it won't refresh indentation more often than necessary. > > Unfortunately, there is a price to pay: > > 1. Initialization will be much longer for large Org files, but I've > added a message to the user saying so. > 2. It is a bit slower, as the algorithm has more things to check. > > > Last point is obviously my main concern. Although not noticeable on my > not-so-recent laptop, I don't know how it behaves on old machines. > > That's why a testing is necessary to determine (bugs and) if it is > usable. Any help welcome. > initial testing seems to show that this works well, very nice. The delay at the beginning is long, and it might be annoying when org pulls in a buffer just to look something up, without org-inhibit-startup scoped into the file loading. Maybe one could arrange for the initialization to happen just before the buffer is first *displayed* (I do not know if that is possible). Just one nitpicking: The idle timer may force updating when not necessary - but using after-change-functions will update after each character inserted. So in fact your code might be updating more often at least while typing - maybe not while looking at the buffer and jumping around. I am not a fast typist, but maybe fast typists will notice significant delays, in particular while writing inside a very long section? Regards - Carsten