From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: org-indent mode not indenting free text? Date: Fri, 3 Dec 2010 23:33:08 +0100 Message-ID: <655A2791-E195-4D7D-B912-543BC281DC16@gmail.com> References: <4CEBF039.6040503@ccbr.umn.edu> <87aakzj2l9.wl%n.goaziou@gmail.com> <87r5ebzsll.wl%dmaus@ictsoc.de> <87oc94hqv2.fsf@Rainer.invalid> <4CF91853.9090001@ccbr.umn.edu> <47210110-87A0-4895-9194-F6ACC1B4EF16@gmail.com> <4CF95F69.3050303@ccbr.umn.edu> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=33690 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POeCz-00083z-DH for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 17:34:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POeCx-0000MN-Ht for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 17:34:29 -0500 Received: from mail-ew0-f43.google.com ([209.85.215.43]:47709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POeCx-0000MD-41 for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 17:34:27 -0500 Received: by ewy22 with SMTP id 22so7249264ewy.30 for ; Fri, 03 Dec 2010 14:34:26 -0800 (PST) In-Reply-To: <4CF95F69.3050303@ccbr.umn.edu> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Erik Iverson Cc: Achim Gratz , emacs-orgmode@gnu.org, Antti Kaihola Hi Erik, thank you for your persistence, and sorry that I have not been taking the time to explain myself clearly, in this way I have made this thread unnecessarily long. OK, lets look at exhibit 1: ((and org-indent-mode (not (org-version-check "23.1.50" "Org Indent mode" :predicate))) (message "org-indent-mode can crash Emacs 23.1 - refusing to turn it on!") This test is run when someone tries to turn on org-indent mode. If this is not Emacs 23.1.50 or later, org-indent mode will not be turned on, and none of the remaining code in org-indent.el will actually run, because the mode is never turned on. Now, exhibit 2: (if (and (not (fboundp 'with-silent-modifications)) (or (< emacs-major-version 23) (and (= emacs-major-version 23) (< emacs-minor-version 2)))) (defmacro with-silent-modifications (&rest body) `(org-unmodified ,@body))) This is code to supply a replacement macro in Emacsen where `with-silent-modifications' was not defined. The idea was that maybe there are a few minor versions of Emacs where this macro is not defined, and where org-indent-mode might still be able to work. Since I did not know exactly when the macro was introduced, I put in some version test which I now see is not very useful at all. Is there anyone here who has Emacs 23.1.50 currently running? Can you tell me if with-silent-modifications is defined in "emacs -q" [1]? If that is the case, then we can remove the entire top-level form. I hope I am making a bit more sense now. Thanks On Dec 3, 2010, at 10:21 PM, Erik Iverson wrote: > > > Carsten Dominik wrote: >> Hi Erik, >> On Dec 3, 2010, at 5:18 PM, Erik Iverson wrote: >>> Just a guess here: This may be some weirdness >>> because the check in org-indent *will* allow >>> people using GNU Emacs 23.1.50 to turn on >>> org-indent, as far as I can tell. >> org-indent-mode should work in 23.1.50, this is the >> release where the fix was made. >>> >>> The message "org-indent-mode can crash Emacs 23.1" >>> does not fully explain if it can also crash 23.1.50. >> Yes, may be this is not so clear. The current setup forbids it >> before 23.1.50, and allows it from 23.1.50. At least that is >> what I meant. Is there a bug? > > No, I did not realize that this is what was indeed meant. > More below... > > > >>>>> Could you back out the change >>>>> (most likely the defmacro for with-silent-modifications in org- >>>>> macs.el, >>>>> even though I have no clue why this would interact with org- >>>>> indent-mode >>>>> as it should not be defined for versions >23.1) and tell us if >>>>> that >>>>> solves your problem (which I can't test because org-indent-mode >>>>> doesn't >>>>> even start on Emacs 23.1)? >>>> Yes it does! I commented out: >>>> ;;(if (or (< emacs-major-version 23) >>>> ;; (and (<= emacs-major-version 23) >>>> ;; (< emacs-minor-version 2))) >>>> ;; (defmacro with-silent-modifications >>>> ;; (org-unmodified))) >>>> and it now works correctly. Thanks a lot! >> I have now changed the definition like this: >> (if (and (not (fboundp 'with-silent-modifications)) >> (or (< emacs-major-version 23) >> (and (= emacs-major-version 23) >> (< emacs-minor-version 2)))) >> (defmacro with-silent-modifications (&rest body) >> `(org-unmodified ,@body))) > > I must admit I don't understand the above macro, > but what I was getting at before was: > > It only appears defined for Emacs < 23.2, > So in particular, 23.1.50 is 'stuck' in > between these two version checks, and maybe > that's causing Antti's issue? > >> May I ask you to pull and check if this is >> working for you out of the box? > > Works for me fine on Emacs 23.2, we will see > if it does for Antti also. > >