From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SBP7OrFBYGQpwAAASxT56A (envelope-from ) for ; Sun, 14 May 2023 04:04:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MDHNOrFBYGTBdAAA9RJhRA (envelope-from ) for ; Sun, 14 May 2023 04:04:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7338B38FDE for ; Sun, 14 May 2023 04:04:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1py155-0003Dm-Qq; Sat, 13 May 2023 22:03:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1py152-0003DZ-8H for emacs-orgmode@gnu.org; Sat, 13 May 2023 22:03:24 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1py150-0003hG-JF for emacs-orgmode@gnu.org; Sat, 13 May 2023 22:03:23 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1aaff9c93a5so77939775ad.2 for ; Sat, 13 May 2023 19:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684029801; x=1686621801; h=mime-version:in-reply-to:reply-to:date:subject:cc:to:from :user-agent:references:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ZPoCqNIw9OSlyxCkNJeFS/MH3P+lXWXjqjyISZy9hQw=; b=Jwo6ocW5Nod9nxPWvJxKgdPYeIuHHHfvtRxC4KKleSmkD3THWXw4Et8IuHiKPUWMfn Wh9JMlV6Rf9RG3C0R3dpwudURw9gbDslYHfqtBc2aUkgJUtmNrTnSY8qRZMIi+qikW+P UhjBf+vGW0jJkDTPxGIQjyyVrnsdosZ6e5kRJ3s5+Qw1AA7tBG28D/jZJVkLCNN7ht18 BJBAe+PIzfhpkaiAePdV7mWOWMjh+Zie2LQxqPBeAN8Y18XWSrJf9GNh3vH0Emuz9RyH WEAK+6WbacQ9u9G1AVv4pwG2BQDqGLjetz+9qLKXK25+3rxnueZxSz29qRCegfwqKQqp oERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684029801; x=1686621801; h=mime-version:in-reply-to:reply-to:date:subject:cc:to:from :user-agent:references:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPoCqNIw9OSlyxCkNJeFS/MH3P+lXWXjqjyISZy9hQw=; b=TXKUACDt+0hWBhFo0jAo0kZsoHBJDtcORM+B+XM9gBClCIFFWOwHLI/fNwwoRagixG upDEFdBtCc2YKnZzdkl1m4idh0fNoU9EHtq/PrCN5yyU5uAtJ3q1un2hlvMCf6ccM+sN AZ2EvpCy06sUnG0Ln0F8PGho9QiTGOXyZcCI6tOLpT8beRZQZPILLxBkqqp5pdESq9en j20sVla020i+U8pAa2vOycIlxjmdKxLCssO4kz7zggjr/OAcm0ZMQF3gpq/JuMZY75Xw sqJRpI3FfniBjFcFW3kBA9Ce1AALP7FMVHlbHMK6r5Y6+CuVTg6QxmJSOX2KcpSlM7ar yDpQ== X-Gm-Message-State: AC+VfDxDIEUX+OHpiFBKQ91w98ey73Pt6xU6sT1gRIm+H4Jh2poQd9cs A9HN/zwuIBJYiuRpOBFDwQ== X-Google-Smtp-Source: ACHHUZ6NopMPeqorJUn8yrDJafp2eJTL++ekHcFXzcAA8KjN5D5473zeV6NgeBIFmDsva6yWsAmk/w== X-Received: by 2002:a17:902:e786:b0:1ac:7543:bcdf with SMTP id cp6-20020a170902e78600b001ac7543bcdfmr21990584plb.31.1684029801099; Sat, 13 May 2023 19:03:21 -0700 (PDT) Received: from Mac-mini.local ([39.171.215.147]) by smtp.gmail.com with ESMTPSA id b9-20020a170902650900b001a6dc4f4a8csm10570558plk.73.2023.05.13.19.03.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 13 May 2023 19:03:20 -0700 (PDT) Message-ID: <64604168.170a0220.99926.5b4f@mx.google.com> X-Google-Original-Message-ID: Received: by Mac-mini.local (Postfix, from userid 501) id 705DA8D3AD60; Sun, 14 May 2023 09:55:13 +0800 (CST) References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> <87wn1cgjij.fsf@localhost> User-agent: mu4e 1.10.3; emacs 30.0.50 From: "Christopher M. Miles" To: Ihor Radchenko Cc: "Christopher M. Miles" , Org-mode Subject: Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` Date: Sun, 14 May 2023 09:54:35 +0800 In-reply-to: <87wn1cgjij.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=numbchild@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684029873; a=rsa-sha256; cv=none; b=UmDnDNdEISQKVjnNFQhtX57g6B267fEZdorPHvL0p8lzCiVZwACLh15Xhcc0RQtbzX/4q3 2AQJ2Ym5JWvapvqWKsoaf0zBvf46lKNebK0m/OzPynSEybfH9HGLEyyYJ/UD0Ta60uzIGI +CT4aYbUQ0WGaRudpPkQ9lpN3pp2FVfxLGC86vibNyczt3bNA1dyuSFN03jpzrAbPMi/z0 794sc0CTHuCoVwTmJ6buZBW2PFjWJtxdM/WdZ+Uqc4zFMefYpcFXhKduweNcPsx/ZP1sxm 3F2f2T7Z8wQkFJrZM6gCO+gOnPF/ePIJ7nlNI3l0duXqXZ9CAmEkHIfWhfOXwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Jwo6ocW5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684029873; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZPoCqNIw9OSlyxCkNJeFS/MH3P+lXWXjqjyISZy9hQw=; b=TeZJBV2i/28MtnpT4PDhQ7Xsdok2YS9hNcz8fJtPHRSbEn7jfOvL9Si+0baM+olyJek2Mb EPqSxbSn3wZr0/4559xTMTIw1uPX1MFev7jqGqRTfHnAnkhBDfhafmDi8EhJg0E/b/HC1v IPg1GuKW8YCmYJvwBbv7ioge50Se9p/Cd10h+P5znHf9svjXPuTytiSmS5Ehaxp8MbYmMY qSGgOOQ+rQ6tTxNvc+YWDjefC5+Rh/rGr3TGRwOl6D9oKfLvVU5GIlCLgZUZ+IbTc0b9d7 cMjZ97YbZKJvXC4GauQkNVJ+b7BmveoI/Jzv0o2VXyk4xIP6WneGEIYkMjj2xQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Jwo6ocW5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.47 X-Spam-Score: -6.47 X-Migadu-Queue-Id: 7338B38FDE X-TUID: kti1XCc/MaCp --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> It would be great if you can come up with a patch. >>> 1. Keeping tags with explicitly assigned key binding indeed makes sense >>> 2. If we limit the number of displayed tags (on top of explicitly >>> assigned), it should be a defcustom. >> >> Here is the patch. >> - (setq tbl fulltable char ?a cnt 0) >> + (setq tbl (seq-filter 'cdr fulltable) char ?a cnt 0) > > Thanks, but it will make the tag selection useless for people who did > not customize explicit tag bindings. > > You should instead only filter when the number of tags exceeds some > customized value. What about like this? #+begin_src emacs-lisp (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) (if (length> shortkeys 0) bound-tags (seq-take fulltable 26))) char ?a cnt 0) #+end_src =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express without mi= sunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmRgP3sACgkQG13xyVro msPg8Af/Whzjn616lVBVcwTDpxOGq26Ifgv7oLWSgUzrJ0WLuieQT6GPyhEGLz1D mIg8UcUXuvhctzEfIjDIywjPoRpGXCbGdsQ3TK5wD8MZuMQca5KpgW3Qzg/HiMrV /4vtyb+SFgyJqDfMhefip+VDWdFStEZRIFRH57GxvG9/VabbwCHQGueN5ZHSEwAl RiZZm432qDxJaybfP8bYMIcKJZh6HES/aqh8IdPsWFckTvg5ZdqGA8NHdpKdZ0pi aGyOHylKkfmnjzUMd6YlOcZUypJzz07sEpVNkaz9/QJgSICcBwvY7NtGZhSGbthj BacCU99o5hkwFWVQOn+mnl8P1uzf4g== =y4ZR -----END PGP SIGNATURE----- --=-=-=--