From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-html link building diff Date: Tue, 27 Apr 2010 08:07:39 +0200 Message-ID: <6104BFDD-B075-4516-81BC-E4A9101DE284@gmail.com> References: <734f7527c1662e217d1ec2ad053118b2.squirrel@mail.panix.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6hGT-00069a-3V for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 05:39:37 -0400 Received: from [140.186.70.92] (port=48278 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6hGO-00066O-Tm for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 05:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6eZp-0007p6-Ma for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 02:47:40 -0400 Received: from ey-out-1920.google.com ([74.125.78.149]:28394) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6eZf-0007nK-BK for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 02:47:20 -0400 Received: by ey-out-1920.google.com with SMTP id 13so262368eye.34 for ; Mon, 26 Apr 2010 23:47:14 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org On Apr 26, 2010, at 9:45 PM, Tom Breton (Tehom) wrote: > > >> I am sure it does - the export function has grown like cancer in the >> run of years. >> Unfortunately, I right now do not have the time to study this >> carefully enough >> to make sure this does not break anything. > >> Tom, maybe you can update the patch to the current master. What I meant here is that you rebase your patch to the current origin/ master and republish it. I have made some small changes to the HTML exporter (should not have conflicts with your changes, I hope...) > > Actually, I don't seem to be able to push to the repository. > Unfortch, my machine isn't that great for hosting a public repository, > as the instructions suggest. Is there something I need to do? Yes. Send me your name on repo.or.cz and I'll add push for you. Please create your own branch and stay on it. > > Or did you mean, base it on the current version of org? I thought I > had because I had just pulled it. > >> Are there any volunteers who can put this patch through the mill? Or >> Tom, maybe >> you first want to implement the other stuff you are thinking about? > > That's half-done already; > > * Mostly, I made the other branches of `cond' use > `org-html-make-link' too. That's done. > > * I'd like to cleanup the test whether to inline images. My first > patch had copied it more or less unchanged from what it was. > > Now the bulk of the test is encapsulated in > `org-html-should-inline-p', but I've yet to make the code use it. > > * And I'd like to make the two sources of name conversion respect > each other. > > * There are now two sources of name conversion: > > * The existing code to convert org files which operates if > `org-export-html-link-org-files-as-html' is non-nil. > > * This changes url type as well as url path > > * org-html-cvt-link-fn, which supports converting via a lookup > table or similar. I need that for org2blog, which posts to a > Blogger-style blog directly from org. > > * Presently this does not treat url type. > > * (For completeness) And it can not convert the name at all. > > * So `org-html-cvt-link-fn' signature may change in the near > future, and I'll probably encapsulate the other conversion, and > then the logic will just be choose one by precedence. > > A couple of notes: > > * I am taking "to make sure this does not break anything" to heart > and I will write some semblance of a test suite for org-html. I'll > post that soon. Awesome. As you have noticed, image inclusion has a number of special cases which I have added over the years and I don't even remember everyting in there. Important things: - Inlining is an issue - attribute handling - figure captions and references to figures > > Everybody, please feel free to contribute any tests of the proper > current behavior to it. > > * Potential snippage: > > * There is a FIXME comment in `org-export-as-html' that's been there > for a long time. I suspect it's been fixed, because I haven't > encountered a problem about not escaping something. > > * "FIXME: do we need to unescape here somewhere?" Yes, this can be removed - we have not had a problem here for quite a while. > > * I don't believe the code just before the `cond' still adds > anything useful. It seems redundant to other code. But I'd like > to hear from others before I dare snip it out. > > That is, the code that begins ";; Make an image out of the > description if that is so wanted" This is for having a clickable Thumbnail - I am not sure if this is also handled elsewhere. Thanks Tom, for taking a look at this mess. - Carsten