emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: Alessandro Bertulli <alessandro.bertulli96@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Opening org-cite links with different application
Date: Wed, 25 May 2022 22:21:15 +0700	[thread overview]
Message-ID: <5fdf44d8-8d70-b882-d20d-c2c52b92ec53@gmail.com> (raw)
In-Reply-To: <87czg1sny1.fsf@gmail.com>

On 25/05/2022 21:10, Alessandro Bertulli wrote:
> 
> I'm not sure if it's the best way to do so, but it worked for me by
> using a lambda:
> 
> (setq citar-file-open-function '(lambda (file)
> 	  (async-shell-command (format-message "sioyek \"%s\"" file))))

First of all, it is unsafe. File names for papers downloaded from 
various sources may have enough fancy characters including double 
quotes, etc. having special meaning for shell.

Use at least `shell-quote-argument' instead of adding double quotes.

Depending on your OS I suggest to have a look at the implementation of 
`browse-url-xdg-open', `browse-url-default-macosx-browser', 
`browse-url-default-windows-browser' for an example how to start 
external viewer process.

On 25/05/2022 18:00, Bruce D'Arcus wrote:
> You just need to set `citar-file-open-function` to your preferred
> function; say xdg-open.

Is there a reason to avoid emacs global or even system global settings 
obtained through mailcap.el? While `mailcap-view-file' is quite new 
addition, the function was inspired by `org-open-file' and the latter 
queries mailcap settings.

Actually I suspect that there may be some problems especially with 
Emacs-27 (see "org--file-default-apps" thread), but the consequences is 
not clear for me yet.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40247
mailcap-mime-data erased when parsing mime parts


  parent reply	other threads:[~2022-05-25 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 14:10 Opening org-cite links with different application Alessandro Bertulli
2022-05-25 14:49 ` Bruce D'Arcus
2022-05-25 15:21 ` Max Nikulin [this message]
2022-05-25 16:00   ` Bruce D'Arcus
2022-05-25 16:46     ` Max Nikulin
2022-05-26 18:45       ` Bruce D'Arcus
2022-05-26 22:17         ` Tim Cross
  -- strict thread matches above, loose matches on Subject: below --
2022-05-27 11:15 Alessandro Bertulli
2022-05-25 16:24 Alessandro Bertulli
2022-05-31 14:53 ` Max Nikulin
2022-06-01 10:33   ` Alessandro Bertulli
2022-06-02 15:53     ` Max Nikulin
2022-05-25 16:16 Alessandro Bertulli
2022-05-25 10:52 Alessandro Bertulli
2022-05-25 11:00 ` Bruce D'Arcus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fdf44d8-8d70-b882-d20d-c2c52b92ec53@gmail.com \
    --to=manikulin@gmail.com \
    --cc=alessandro.bertulli96@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).