From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iIWZDWsteF+AOwAA0tVLHw (envelope-from ) for ; Sat, 03 Oct 2020 07:51:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oPSJCWsteF9sZwAA1q6Kng (envelope-from ) for ; Sat, 03 Oct 2020 07:51:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA0799404DF for ; Sat, 3 Oct 2020 07:51:06 +0000 (UTC) Received: from localhost ([::1]:39690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOcJt-0000ho-GO for larch@yhetil.org; Sat, 03 Oct 2020 03:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOcJE-0000gj-Tc for emacs-orgmode@gnu.org; Sat, 03 Oct 2020 03:50:24 -0400 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:36927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOcJC-0005LU-Pk; Sat, 03 Oct 2020 03:50:24 -0400 Received: by mail-pj1-x1042.google.com with SMTP id kk9so2358446pjb.2; Sat, 03 Oct 2020 00:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:references:user-agent:from:to:cc:subject:reply-to :in-reply-to:date:mime-version; bh=YjHu0FhH5gbH8p9iN3VNzFhpdPxrsJ0FVHZNJKZi2Ko=; b=iekWeOh3lmoeSRgfb+Q/TEWiHi5Ax5lNBnHoTGaJZUc58zH3Ch0AETcb5mAhjH/Yjp PooA9ui1GAqk26sB+h9rX7uO31erpYAJ9VjiKa8O+x1MgIBkJSAY4xuCP0Wzpb4XUh+z np7+T7ZW2fwYh5U7vyKAiuV/IQFc5Q5XjJ4XAKT8wvHt/uP3E4WCWFuUFvpfnLBeSfeg bUpyKDTruG5yPKigNMyb0LQyL8GbjVBmODLRjJspU2bE1BWzuUz2yg8xNdaxOouGhODE 2sDsSwDy68aAFNdOkS/saBzALuBIq15oWzIvyaeU8mvIYnEplBA1oYBq2lxu1rdDVFHs fHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:references:user-agent:from:to:cc :subject:reply-to:in-reply-to:date:mime-version; bh=YjHu0FhH5gbH8p9iN3VNzFhpdPxrsJ0FVHZNJKZi2Ko=; b=AZ+EeMz/zcc9744oTpgcLPZiDpAuZCcYaFWICwcUIOictnqvALZN4X3E/PLNdFpvq9 vBrJdWhEaMSwa+PRFF6x6UMDO5Lax/w5eY9Cvf5TVD8VIGk0dpclp2OXzRTW75+hB36M h8mTZ4GK7oczRI2OBc0SQzAKyogdPyGSYsPK2mYL6AfclJlG2eST/oRFWCJzuvTIQgJ5 RrWdL61g6sHlI93c0T32Cq0roSj1tAePGHYrkXlTQaXcRpSRJ7n19u3CKJW7nAGCgAmC hYkt3jdDKozZDyg9kFbvMGZ3CxfRqzdPc5A7WQ6btq+wUThPrjac67RPT04cIBLqLSC0 nXMw== X-Gm-Message-State: AOAM5311FmeQXcM+PxD1xt62S6J8fp0s1ZhTRyeCqglnqdQh9eSDxuk/ a/De04hfxlYmDRXu0EiPAg== X-Google-Smtp-Source: ABdhPJwDTiY+pyNcElBlRzTAXKxEu7YusoXW32cTNFIUQfcCJb+F79PTypRuvfKZNklnVurxAIJOYQ== X-Received: by 2002:a17:90b:1804:: with SMTP id lw4mr465723pjb.9.1601711418896; Sat, 03 Oct 2020 00:50:18 -0700 (PDT) Received: from dark.localdomain ([183.246.147.142]) by smtp.gmail.com with ESMTPSA id j6sm4573560pfi.129.2020.10.03.00.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 00:50:17 -0700 (PDT) Message-ID: <5f782d39.1c69fb81.f8fe3.9531@mx.google.com> X-Google-Original-Message-ID: <877ds7epa4.fsf@numbchild@gmail.com> Received: by dark.localdomain (Postfix, from userid 1000) id 6BBB73C01B4; Sat, 3 Oct 2020 15:34:27 +0800 (CST) References: <50f165b2-bdaf-4861-aab5-122cfef7d67c@www.fastmail.com> <5f6aa2e2.1c69fb81.9bff7.9127@mx.google.com> <87k0wkheik.fsf@gnu.org> <87lfh060pb.fsf@localhost> <87tuviqyi4.fsf@kyleam.com> User-agent: mu4e 1.5.5; emacs 28.0.50 From: stardiviner To: Kyle Meyer Subject: Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)] In-reply-to: <87tuviqyi4.fsf@kyleam.com> Date: Sat, 03 Oct 2020 15:34:27 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1042; envelope-from=numbchild@gmail.com; helo=mail-pj1-x1042.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: B Goodr , Dmitrii Korobeinikov , Ihor Radchenko , Bastien , emacs-orgmode@gnu.org, Nicholas Savage Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=iekWeOh3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: tWYKp32Ikeh3 Kyle Meyer writes: > Ihor Radchenko writes: > >> Subject: [PATCH] Do not remove trailing newline when deleting planning info >> line. >> >> * lisp/org.el (org-add-planning-info): Remove front newline instead of >> trailing newline when deleting planning info is completetly removed >> from a heading. Fixes "Cycling through TODO workflow joins the next >> line onto the current one". > > Did you intended to send a different patch? This looks to be the same > patch you sent at . > > Also, can someone could provide an example case that was fixed by > ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)? > The report that prompted that commit didn't include one: > https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com > > I tried with > > --8<---------------cut here---------------start------------->8--- > > * TODO a > > * TODO b > --8<---------------cut here---------------end--------------->8--- > > If I understand the original message by Dmitrii (+cc), the request was > that, since starting up folded shows the first heading as > > * TODO a... > > tab should be able to fold the heading back to that state after > expansion. But, trying with the current master (16f505db2), tab still > doesn't fold that heading on my end. Unless we have a concrete reason > to keep ee3c3b554, reverting it might be the best fix for this thread's > issue. Waited many days, seems no useful patch available. I suggest to revert that commit. -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3