From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Seeger Subject: Re: Bug: org-capture-refile doc inconsistency, refile bug [8.3.1 (8.3.1-129-ga7c8d2-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20150921/)] Date: Fri, 25 Sep 2015 13:37:30 +0200 Message-ID: <5F2C244C-C240-4956-9479-7D3301709B47@thenybble.de> References: <87io71qrbt.wl-jan.seeger@thenybble.de> <87twqjk06p.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----9HK52ERYGQRIOAB3EFZ7ANKDM018NG" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfRJq-0001sC-Bp for emacs-orgmode@gnu.org; Fri, 25 Sep 2015 07:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfRJm-0003tw-1D for emacs-orgmode@gnu.org; Fri, 25 Sep 2015 07:37:37 -0400 Received: from [2a01:488:66:1000:57e6:57cd:0:1] (port=43123 helo=eins.thenybble.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfRJl-0003se-O9 for emacs-orgmode@gnu.org; Fri, 25 Sep 2015 07:37:33 -0400 In-Reply-To: <87twqjk06p.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org ------9HK52ERYGQRIOAB3EFZ7ANKDM018NG Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Hello! Thanks for your reply. However, the current behavior definitely results in bugs when refiling from the capture buffer (newlines don't get deleted properly, for example). I'll look into how to correctly set the position for org-capture-finalize after the refile then, and try to make a patch for that. Regards, Jan Am 24. September 2015 22:54:38 MESZ, schrieb Nicolas Goaziou : >Hello, > >Jan Seeger writes: > >> I've fixed this bug for me by reversing the order of finalization and >> refiling, as stated in the documentation. I've attached a patch to do >> this, but I'm not entirely sure about the side effects caused by the >> patch. The test suite does pass though. If someone could weigh in on >> this, I'd be grateful! > >Thank you for the patch. However, it contradicts >47b0eec8dc39990731f400640d64ab70a8356ccd. > >See thread starting > for an >explanation. > > >Regards, > >-- >Nicolas Goaziou -- Diese Nachricht wurde von meinem Mobiltelefon gesendet. ------9HK52ERYGQRIOAB3EFZ7ANKDM018NG Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Hello!
Thanks for your reply. However, the current behavior definitely results in bugs when refiling from the capture buffer (newlines don't get deleted properly, for example).

I'll look into how to correctly set the position for org-capture-finalize after the refile then, and try to make a patch for that.
Regards,
Jan

Am 24. September 2015 22:54:38 MESZ, schrieb Nicolas Goaziou <mail@nicolasgoaziou.fr>:
Hello,

Jan Seeger <jan.seeger@thenybble.de> writes:

 I've fixed this bug for me by reversing the order of finalization and
 refiling, as stated in the documentation. I've attached a patch to do
 this, but I'm not entirely sure about the side effects caused by the
 patch. The test suite does pass though. If someone could weigh in on
 this, I'd be grateful!

Thank you for the patch. However, it contradicts
47b0eec8dc39990731f400640d64ab70a8356ccd.

See thread starting
<http://permalink.gmane.org/gmane.
 emacs.orgmode/78027> for an
explanation.


Regards,

--
Diese Nachricht wurde von meinem Mobiltelefon gesendet. ------9HK52ERYGQRIOAB3EFZ7ANKDM018NG--