From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Let orgtbl export the last table line with a different ending. Date: Fri, 29 Feb 2008 11:03:29 +0100 Message-ID: <5C3CDA7E-ABC8-4565-9072-4AFD32989425@science.uva.nl> References: <87zltksk90.fsf@sparse.yi.org> Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV25Y-0008Li-ST for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 05:03:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV25X-0008KV-LP for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 05:03:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV25X-0008KB-DF for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 05:03:35 -0500 Received: from ug-out-1314.google.com ([66.249.92.172]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JV25W-0007Du-Tg for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 05:03:35 -0500 Received: by ug-out-1314.google.com with SMTP id a2so222771ugf.48 for ; Fri, 29 Feb 2008 02:03:34 -0800 (PST) In-Reply-To: <87zltksk90.fsf@sparse.yi.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jason Riedy Cc: emacs-orgmode@gnu.org Hi Jason, nice idea, I would like to take this patch. However, I think it should be done such that if the user only specifies :lend, then the default for :llend should be that. Would you like to fix this minor issue and then resubmit your patch? - Carsten On Feb 29, 2008, at 1:02 AM, Jason Riedy wrote: > If the last line ends with the default :lend in LaTeX (\\), > a horizontal line placed after the table will have too much > preceeding vertical space. > > Signed-off-by: Jason Riedy > --- > Yeah, this is the cheap version. The "better" version > would break the loop into header and body pieces and allow > a :hllend. But right now I'm splicing all my tables for > other reasons. > > org.el | 7 ++++--- > org.texi | 5 +++-- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/org.el b/org.el > index 476cee8..a4e0e43 100644 > --- a/org.el > +++ b/org.el > @@ -11771,6 +11771,7 @@ Valid parameters are > > :lstart String to start a new table line. > :lend String to end a table line > +:llend String to end the last line of a table > :sep Separator between two fields > :lfmt Format for entire line, with enough %s to capture all > fields. > If this is present, :lstart, :lend, and :sep are ignored. > @@ -11832,7 +11833,7 @@ directly by `orgtbl-send-table'. See manual." > (push (concat > (org-get-param p h i :lstart :hlstart) > (mapconcat 'identity line (org-get-param p h i :sep :hsep)) > - (org-get-param p h i :lend :hlend)) > + (org-get-param p h i (if table :lend :llend) :hlend)) > rtn)))) > > (unless splicep > @@ -11869,7 +11870,7 @@ this function is called." > (list > :tstart (concat "\\begin{tabular}{" alignment "}") > :tend "\\end{tabular}" > - :lstart "" :lend " \\\\" :sep " & " > + :lstart "" :lend " \\\\" :llend "" :sep " & " > :efmt "%s\\,(%s)" :hline "\\hline"))) > (orgtbl-to-generic table (org-combine-plists params2 params)))) > > @@ -11934,7 +11935,7 @@ this function is called." > (list > :tstart (concat "@multitable @columnfractions " colfrac) > :tend "@end multitable" > - :lstart "@item " :lend "" :sep " @tab " > + :lstart "@item " :lend "" :llend "" :sep " @tab " > :hlstart "@headitem "))) > (orgtbl-to-generic table (org-combine-plists params2 params)))) > > diff --git a/org.texi b/org.texi > index fab72ec..daad533 100644 > --- a/org.texi > +++ b/org.texi > @@ -8228,7 +8228,7 @@ generic translator. Here is the entire code: > (list > :tstart (concat "\\begin@{tabular@}@{" alignment "@}") > :tend "\\end@{tabular@}" > - :lstart "" :lend " \\\\" :sep " & " > + :lstart "" :lend " \\\\" :llend "" :sep " & " > :efmt "%s\\,(%s)" :hline "\\hline"))) > (orgtbl-to-generic table (org-combine-plists params2 params)))) > @end group > @@ -8256,7 +8256,8 @@ a single line!): > > @example > #+ORGTBL: SEND test orgtbl-to-generic :tstart "!BTBL!" :tend "!ETBL!" > - :lstart "!BL! " :lend " !EL!" :sep "\t" > + :lstart "!BL! " :lend " !EL!" :llend > " !EL!" > + :sep "\t" > @end example > > @noindent > -- > 1.5.4.3 > > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode