From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Perl Subject: Bug: org-agenda-category-filter-preset in org-agenda-custom-commands with org-agenda-sticky does not work [9.1.2 (release_9.1.2-99-g4d828b @ /home/cperl/git/org-mode/lisp/)] Date: Thu, 12 Oct 2017 23:15:01 -0400 Message-ID: <59e02fb6.1462370a.fffe8.51c4@mx.google.com> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2qRK-00014h-1i for emacs-orgmode@gnu.org; Thu, 12 Oct 2017 23:15:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2qRG-0003zH-1y for emacs-orgmode@gnu.org; Thu, 12 Oct 2017 23:15:10 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:54233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2qRF-0003xM-S8 for emacs-orgmode@gnu.org; Thu, 12 Oct 2017 23:15:05 -0400 Received: by mail-qk0-x236.google.com with SMTP id y23so3521225qkb.10 for ; Thu, 12 Oct 2017 20:15:04 -0700 (PDT) Received: from localhost (ool-4576adaf.dyn.optonline.net. [69.118.173.175]) by smtp.gmail.com with ESMTPSA id w20sm10285905qkb.95.2017.10.12.20.15.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 20:15:02 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org When using org-agenda-custom-commands with org-agenda-category-filter-preset and org-agenda-sticky, it seems as though changes to org-agenda-category-filter are global, even though the variable is made buffer local. >From the limited digging I've done, it seems that setting the :preset-filter property for org-agenda-category-filter affects all agenda buffers, not just one. To reproduce, take the following org file: ---8<--- * Foo :PROPERTIES: :CATEGORY: foo :END: ** TODO Foo todo one DEADLINE: <2017-10-13 Fri> - foo 1 * Bar :PROPERTIES: :CATEGORY: bar :END: ** TODO Bar todo one DEADLINE: <2017-10-13 Fri> - bar 1 --->8--- And the following elisp file to setup a minimal environment: ---8<--- (require 'org) (setq org-agenda-files (list (expand-file-name "repro.org"))) (setq org-agenda-sticky t) (setq org-agenda-custom-commands '(("f" "foo" ((agenda "" ()) (tags-todo "+CATEGORY=\"foo\"" ())) ((org-agenda-category-filter-preset '("+foo")))) ("b" "bar" ((agenda "" ()) (tags-todo "+CATEGORY=\"bar\"" ())) ((org-agenda-category-filter-preset '("+bar")))))) (global-set-key (kbd "C-c a") #'org-agenda) --->8--- Then run (something like): emacs -nw -Q -L ~/git/org-mode/lisp -l repro.el repro.org Followed by: C-c a f C-c a b C-x o r I would expect pressing `r' in the `*Org Agenda(f)*' buffer would keep the original `org-agenda-category-filter-preset' and that the preset in `*Org Agenda(b)*' should have no bearing on it. But, as you can (probably) see from the mode line, the filter is set to "+bar", and refreshing the buffer causes all the TODOs to be lost because it now has the wrong filter. Emacs : GNU Emacs 25.3.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.22.17) of 2017-09-14 Package: Org mode version 9.1.2 (release_9.1.2-99-g4d828b @ /home/cperl/git/org-mode/lisp/) current state: ============== (setq org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate) org-occur-hook '(org-first-headline-recenter) org-metaup-hook '(org-babel-load-in-session-maybe) org-confirm-shell-link-function 'yes-or-no-p org-agenda-sticky t org-agenda-custom-commands '(("f" "foo" ((agenda "" nil) (tags-todo "+CATEGORY=\"foo\"" nil)) ((org-agenda-category-filter-preset (quote ("+foo"))))) ("b" "bar" ((agenda "" nil) (tags-todo "+CATEGORY=\"bar\"" nil)) ((org-agenda-category-filter-preset (quote ("+bar"))))) ) org-after-todo-state-change-hook '(org-clock-out-if-current) org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-babel-pre-tangle-hook '(save-buffer) org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-block-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes) org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"] org-archive-hook '(org-attach-archive-delete-maybe) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-confirm-elisp-link-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-link-parameters '(("id" :follow org-id-open) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("doi" :follow org--open-doi-link) ("elisp" :follow org--open-elisp-link) ("file" :complete org-file-complete-link) ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path)))) ("help" :follow org--open-help-link) ("http" :follow (lambda (path) (browse-url (concat "http:" path)))) ("https" :follow (lambda (path) (browse-url (concat "https:" path)))) ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path)))) ("news" :follow (lambda (path) (browse-url (concat "news:" path)))) ("shell" :follow org--open-shell-link)) org-agenda-files '("/home/cperl/tmp/2017-10-05/repro.org") org-clock-out-hook '(org-clock-remove-empty-clock-drawer) )