From: Thierry Banel <tbanelwebmin@free.fr>
To: emacs-orgmode@gnu.org
Subject: spee-up table refresh
Date: Sun, 08 Jan 2017 18:28:27 +0100 [thread overview]
Message-ID: <587276BB.9000008@free.fr> (raw)
Re-computing a large table is slow. Hereafter is a test case for a 1000
row table. My computer refreshes it in 44 seconds.
Here is a fast-and-dirty-not-to-be-commited patch which speed-up the
refresh to less than 1 second. I just removed the last 3 lines of
(org-at-table-p).
I don't understand those 3 lines, but everything still works fine
without them (the 688 tests work as expected). Those lines indirectly
call (org-element--cache-put) a quadratic number of times. For a 1000
rows table this is 501500 times (about 1000x1000/2 times).
#+BEGIN_SRC elisp :results none
(defun org-at-table-p (&optional table-type)
"Non-nil if the cursor is inside an Org table.
If TABLE-TYPE is non-nil, also check for table.el-type tables.
If `org-enable-table-editor' is nil, return nil unconditionally."
(and
org-enable-table-editor
(save-excursion
(beginning-of-line)
(looking-at-p (if table-type "[ \t]*[|+]" "[ \t]*|")))
))
; (or (not (derived-mode-p 'org-mode))
; (let ((e (org-element-lineage (org-element-at-point) '(table) t)))
; (and e (or table-type (eq (org-element-property :type e) 'org)))))))
#+END_SRC
Here is a test case.
1- First create a 1000 row table:
#+BEGIN_SRC elisp :results none
(goto-char (point-max))
(let ((i 1000))
(while (> i 0)
(insert (format "| %4s | |\n" i))
(setq i (1- i))))
(insert "#+TBLFM: $2=$1*10\n")
#+END_SRC
2- Then, with point in the table, type C-u C-c *
Regards,
Thierry
next reply other threads:[~2017-01-08 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 17:28 Thierry Banel [this message]
2017-01-08 23:24 ` spee-up table refresh Nicolas Goaziou
2017-01-09 22:27 ` Thierry Banel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587276BB.9000008@free.fr \
--to=tbanelwebmin@free.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).