From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Org-mode version 6.32trans (release_6.32b.190.g1818); LAST_MOBILE_CHANGE line bumps local variable line Date: Fri, 13 Nov 2009 00:51:49 +0100 Message-ID: <58121DF2-2300-4E5F-9E75-5273E095FA02@gmail.com> References: <87hbsz8x01.fsf@zancanda.staticcling.org> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8jSM-0005rj-BK for emacs-orgmode@gnu.org; Thu, 12 Nov 2009 18:52:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8jSG-0005oq-NN for emacs-orgmode@gnu.org; Thu, 12 Nov 2009 18:52:00 -0500 Received: from [199.232.76.173] (port=56600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8jSF-0005oQ-TN for emacs-orgmode@gnu.org; Thu, 12 Nov 2009 18:51:55 -0500 Received: from fg-out-1718.google.com ([72.14.220.152]:13481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8jSF-0003u2-AR for emacs-orgmode@gnu.org; Thu, 12 Nov 2009 18:51:55 -0500 Received: by fg-out-1718.google.com with SMTP id l26so1116425fgb.12 for ; Thu, 12 Nov 2009 15:51:54 -0800 (PST) In-Reply-To: <87hbsz8x01.fsf@zancanda.staticcling.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Charles Sebold Cc: emacs-orgmode@gnu.org Hi Charles, good catch, thank you! - Carsten On Nov 12, 2009, at 6:28 PM, Charles Sebold wrote: > In org-mobile-timestamp-buffer(), it tries to insert the > LAST_MOBILE_CHANGE timestamp on the first line if there isn't already > one. > > I think this should check first to see if the first line has local > variables, for example: > > # -*- mode: org; coding: utf-8; -*- > > ...and it should skip past that line if it's there. Any chance of > changing that? > > (The workaround for the moment is to make sure that there is always a > timestamp line present already, and that's fine, but this could > surprise > somebody who wasn't expecting it - like me, until I tracked this > down.) > > Maybe it could be something like: > > --- a/lisp/org-mobile.el > +++ b/lisp/org-mobile.el > @@ -738,10 +738,13 @@ If BEG and END are given, only do this in that > region." > (save-restriction > (widen) > (goto-char (point-min)) > - (when (re-search-forward > + (if (re-search-forward > "^\\([ \t]*\\)#\\+LAST_MOBILE_CHANGE:.*\n?" nil t) > - (goto-char (match-end 1)) > - (delete-region (point) (match-end 0))) > + (progn > + (goto-char (match-end 1)) > + (delete-region (point) (match-end 0))) > + (if (looking-at ".*-\\*-.*-\\*-") > + (forward-line 1))) > (insert "#+LAST_MOBILE_CHANGE: " > (format-time-string "%Y-%m-%d %T") "\n"))))) > > Emacs : GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) > of 2009-11-11 on CT-SEBOLDCR-T4C > Package: Org-mode version 6.32trans (release_6.32b.190.g1818) > -- > Charles Sebold > http://merbc.invigorated.org/ > http://triablogue.blogspot.com/ > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten