From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Hetzner Subject: Re: [PATCH] org-attach.el: Get attachments from git annex Date: Mon, 08 Feb 2016 21:25:25 -0800 Message-ID: <56b97846.594b620a.c8dc8.ffff8edc@mx.google.com> References: <568b532e.d111620a.b25a8.ffffbb7c@mx.google.com> <87poxg8s22.fsf@kyleam.com> <568c6aaa.c345620a.7f4da.6359@mx.google.com> <56a5b193.ca77420a.1551e.667c@mx.google.com> <87lh7dz79f.fsf@gmx.us> <56a70513.6861420a.33633.5843@mx.google.com> <87egd4u6tq.fsf@kyleam.com> <56a7a139.885d620a.6b777.576d@mx.google.com> <87io2gb5xh.fsf@kyleam.com> <87oac8hu9p.fsf@gmx.us> <56a87251.0e2a620a.4811f.fffff1c6@mx.google.com> <87lh79t04p.fsf@kyleam.com> <56b2c213.08e5420a.3d619.ffffd033@mx.google.com> <87oabu3uc0.fsf@gmx.us> <56b77bb8.9447620a.f3b5a.1c05@mx.google.com> <87io20qmaz.fsf@Rainer.invalid> Reply-To: Erik Hetzner Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT0ns-0001FQ-VY for emacs-orgmode@gnu.org; Tue, 09 Feb 2016 00:25:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT0no-00084C-V6 for emacs-orgmode@gnu.org; Tue, 09 Feb 2016 00:25:32 -0500 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:34419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT0no-000845-Bn for emacs-orgmode@gnu.org; Tue, 09 Feb 2016 00:25:28 -0500 Received: by mail-pa0-x22a.google.com with SMTP id kp3so2168276pab.1 for ; Mon, 08 Feb 2016 21:25:27 -0800 (PST) In-Reply-To: <87io20qmaz.fsf@Rainer.invalid> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org On Sun, 07 Feb 2016 12:48:20 -0800, Achim Gratz wrote: >=20 > Erik Hetzner writes: > > Thank you for all your feedback on this code! I=E2=80=99m really happy = with how it > > turned out, and glad it is in master now. >=20 > Please fix the tests to not fail (preferrably not run) if git-annex is > not installed. >=20 > Also, revert the patch to mk/targets.mk; $(RMR) already includes the > '--force' flag, so it can remove write protected files just fine. If > it's write protecting directories then that would be stupid, but still > no reason to chmod all files. Hi Achim, Sorry - I misunderstood how `org-test-for-executable' works. I=E2=80=99ll f= ix the issue. As for the rm -rf, it does not work in the way you suggest, at least on ubu= ntu GNU/Linux. Here is the result I get locally without the chmod: make cleantest make[1]: Entering directory '/home/egh/c/org-mode' rm -fr /tmp/tmp-orgtest rm: cannot remove =E2=80=98/tmp/tmp-orgtest/org-annex-test18033fml/.git/ann= ex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1= ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd= 2a1ec0fb85d299a192a447=E2=80=99: Permission denied rm: cannot remove =E2=80=98/tmp/tmp-orgtest/org-annex-test18033Scf/.git/ann= ex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1= ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd= 2a1ec0fb85d299a192a447=E2=80=99: Permission denied rm: cannot remove =E2=80=98/tmp/tmp-orgtest/org-annex-test172167kl/.git/ann= ex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1= ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd= 2a1ec0fb85d299a192a447=E2=80=99: Permission denied rm: cannot remove =E2=80=98/tmp/tmp-orgtest/org-annex-test17216uaf/.git/ann= ex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1= ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd= 2a1ec0fb85d299a192a447=E2=80=99: Permission denied mk/targets.mk:163: recipe for target 'cleantest' failed make[1]: *** [cleantest] Error 1 make[1]: Leaving directory '/home/egh/c/org-mode' mk/targets.mk:103: recipe for target 'test' failed make: *** [test] Error 2 If you have a better suggestion to this issue I=E2=80=99d love to know! I= =E2=80=99m not sure what the best fix is here. best, Erik