From: Erik Hetzner <egh@e6h.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-attach.el: Get attachments from git annex
Date: Mon, 08 Feb 2016 21:25:25 -0800 [thread overview]
Message-ID: <56b97846.594b620a.c8dc8.ffff8edc@mx.google.com> (raw)
In-Reply-To: <87io20qmaz.fsf@Rainer.invalid>
On Sun, 07 Feb 2016 12:48:20 -0800,
Achim Gratz <Stromeko@nexgo.de> wrote:
>
> Erik Hetzner writes:
> > Thank you for all your feedback on this code! I’m really happy with how it
> > turned out, and glad it is in master now.
>
> Please fix the tests to not fail (preferrably not run) if git-annex is
> not installed.
>
> Also, revert the patch to mk/targets.mk; $(RMR) already includes the
> '--force' flag, so it can remove write protected files just fine. If
> it's write protecting directories then that would be stupid, but still
> no reason to chmod all files.
Hi Achim,
Sorry - I misunderstood how `org-test-for-executable' works. I’ll fix the issue.
As for the rm -rf, it does not work in the way you suggest, at least on ubuntu
GNU/Linux. Here is the result I get locally without the chmod:
make cleantest
make[1]: Entering directory '/home/egh/c/org-mode'
rm -fr /tmp/tmp-orgtest
rm: cannot remove ‘/tmp/tmp-orgtest/org-annex-test18033fml/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’: Permission denied
rm: cannot remove ‘/tmp/tmp-orgtest/org-annex-test18033Scf/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’: Permission denied
rm: cannot remove ‘/tmp/tmp-orgtest/org-annex-test172167kl/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’: Permission denied
rm: cannot remove ‘/tmp/tmp-orgtest/org-annex-test17216uaf/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’: Permission denied
mk/targets.mk:163: recipe for target 'cleantest' failed
make[1]: *** [cleantest] Error 1
make[1]: Leaving directory '/home/egh/c/org-mode'
mk/targets.mk:103: recipe for target 'test' failed
make: *** [test] Error 2
If you have a better suggestion to this issue I’d love to know! I’m not sure
what the best fix is here.
best, Erik
next prev parent reply other threads:[~2016-02-09 5:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 5:09 [PATCH] org-attach.el: Fetch attachments from git annex Erik Hetzner
2016-01-05 5:30 ` Eric Abrahamsen
2016-01-05 6:11 ` Erik Hetzner
2016-01-05 6:36 ` Kyle Meyer
2016-01-05 9:56 ` Rasmus
2016-01-05 17:14 ` Kyle Meyer
2016-01-05 18:16 ` Rasmus
2016-01-05 19:30 ` Kyle Meyer
2016-01-05 21:55 ` Rasmus
2016-01-06 5:43 ` Kyle Meyer
2016-01-06 1:27 ` Erik Hetzner
2016-01-06 9:37 ` Rasmus
2016-01-05 6:21 ` Kyle Meyer
2016-01-06 1:15 ` Erik Hetzner
2016-01-25 5:24 ` Erik Hetzner
2016-01-25 21:19 ` Rasmus
2016-01-25 4:34 ` Erik Hetzner
2016-01-26 7:40 ` Kyle Meyer
2016-01-26 16:39 ` Erik Hetzner
2016-01-26 17:34 ` Kyle Meyer
2016-01-26 22:04 ` Rasmus
2016-01-25 4:34 ` [PATCH] org-attach.el: Get " Erik Hetzner
2016-01-27 22:20 ` Rasmus
2016-02-01 3:32 ` Erik Hetzner
2016-01-29 5:39 ` Kyle Meyer
2016-01-25 4:34 ` Erik Hetzner
2016-02-05 2:41 ` Kyle Meyer
2016-02-06 12:18 ` Rasmus
2016-02-07 17:15 ` Erik Hetzner
2016-02-07 20:48 ` Achim Gratz
2016-02-09 5:25 ` Erik Hetzner [this message]
2016-02-09 19:40 ` Achim Gratz
2016-02-09 21:12 ` Erik Hetzner
2016-02-09 22:19 ` Achim Gratz
2016-02-11 2:24 ` Erik Hetzner
2016-02-11 18:57 ` Achim Gratz
2016-02-09 5:40 ` [PATCH] testing/lisp/test-org-attach-annex.el: New file Erik Hetzner
2016-02-14 11:50 ` Achim Gratz
2016-01-26 5:31 ` [PATCH] org-attach.el: Fetch attachments from git annex Erik Hetzner
2016-01-26 22:10 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b97846.594b620a.c8dc8.ffff8edc@mx.google.com \
--to=egh@e6h.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).