From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH] Fix the single quote printed in the message printed by
 org-table-edit-formulas
Date: Thu, 10 Mar 2016 08:05:49 -0800
Message-ID: <56E19B5D.9060707@cs.ucla.edu>
References: <CAFyQvY2GcivLbGTjhAA3JoMFPxfaE0==0t2TwFkxA40ULs+DZQ@mail.gmail.com>
	<87twkelm5u.fsf@nicolasgoaziou.fr>
	<CAFyQvY1wSF_K7ZmrwGg3WfOFmDNrdDon7-TWUdz2oyBfmy6vKQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48335)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1ae363-0007uR-V5
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 11:05:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1ae35z-000859-PM
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 11:05:55 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42331)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1ae35z-00084w-J7
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 11:05:51 -0500
In-Reply-To: <CAFyQvY1wSF_K7ZmrwGg3WfOFmDNrdDon7-TWUdz2oyBfmy6vKQ@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Kaushal Modi <kaushal.modi@gmail.com>, emacs-org list <emacs-orgmode@gnu.org>

On 03/10/2016 07:33 AM, Kaushal Modi wrote:
>
>     Shouldn't this be handled by `substitute-command-keys' already?
>     The fix
>     looks like a hack.
>
>
> I don't think this has anything to do with substitute-command-keys. 
> That function simply returns a string.

Right, 'message' and 'substitute-command-keys' both turn apostrophe into 
right single quote, so if you really want an apostrophe you need to 
escape it, as Kashal's patch does.

You need to escape the output of substitute-command-keys anyway, in case 
it returns a string containing '%', which 'message' would incorrectly 
interpret as a format specifier.