From: Paul Eggert <eggert@cs.ucla.edu>
To: Kaushal Modi <kaushal.modi@gmail.com>,
emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas
Date: Thu, 10 Mar 2016 08:05:49 -0800 [thread overview]
Message-ID: <56E19B5D.9060707@cs.ucla.edu> (raw)
In-Reply-To: <CAFyQvY1wSF_K7ZmrwGg3WfOFmDNrdDon7-TWUdz2oyBfmy6vKQ@mail.gmail.com>
On 03/10/2016 07:33 AM, Kaushal Modi wrote:
>
> Shouldn't this be handled by `substitute-command-keys' already?
> The fix
> looks like a hack.
>
>
> I don't think this has anything to do with substitute-command-keys.
> That function simply returns a string.
Right, 'message' and 'substitute-command-keys' both turn apostrophe into
right single quote, so if you really want an apostrophe you need to
escape it, as Kashal's patch does.
You need to escape the output of substitute-command-keys anyway, in case
it returns a string containing '%', which 'message' would incorrectly
interpret as a format specifier.
next prev parent reply other threads:[~2016-03-10 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 16:18 [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas Kaushal Modi
2016-03-10 9:25 ` Nicolas Goaziou
2016-03-10 15:33 ` Kaushal Modi
2016-03-10 16:05 ` Paul Eggert [this message]
2016-03-10 16:00 ` Kyle Meyer
2016-03-10 16:38 ` Kyle Meyer
2016-03-10 16:41 ` Kaushal Modi
2016-03-10 17:47 ` Kaushal Modi
2016-03-10 18:24 ` Kaushal Modi
2016-03-11 1:39 ` Paul Eggert
2016-03-11 3:22 ` Kaushal Modi
2016-03-11 4:30 ` Kyle Meyer
2016-03-11 4:55 ` Kaushal Modi
2016-03-11 5:12 ` Kyle Meyer
2016-03-11 17:44 ` Kaushal Modi
2016-03-11 18:47 ` Kyle Meyer
2016-03-11 19:16 ` Kyle Meyer
2016-03-12 4:01 ` Kyle Meyer
2016-03-12 4:57 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E19B5D.9060707@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).