From mboxrd@z Thu Jan  1 00:00:00 1970
From: Erik Hetzner <egh@e6h.org>
Subject: Re: [PATCH] org-attach.el: Fetch attachments from git annex
Date: Tue, 05 Jan 2016 17:15:21 -0800
Message-ID: <568c6aaa.c345620a.7f4da.6359@mx.google.com>
References: <568b532e.d111620a.b25a8.ffffbb7c@mx.google.com>
	<87poxg8s22.fsf@kyleam.com>
Reply-To: Erik Hetzner <egh@e6h.org>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehetzner@gmail.com>) id 1aGchE-0007MN-Jr
	for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 20:15:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehetzner@gmail.com>) id 1aGchA-0008Bw-JU
	for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 20:15:28 -0500
Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:32773)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehetzner@gmail.com>) id 1aGchA-0008BK-CY
	for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 20:15:24 -0500
Received: by mail-pf0-x233.google.com with SMTP id q63so193228768pfb.0
	for <emacs-orgmode@gnu.org>; Tue, 05 Jan 2016 17:15:24 -0800 (PST)
In-Reply-To: <87poxg8s22.fsf@kyleam.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org

Thanks for the feedback, Kyle! I will make these changes and resubmit.

And thanks for the pointer to =3Dgit annex find PATH=3D. I think I can use =
that to
check if a file needs to be fetched.

(more below)

On Mon, 04 Jan 2016 22:21:41 -0800,
Kyle Meyer <kyle@kyleam.com> wrote:
>=20
> Thanks for the patch.
>
> [=E2=80=A6]
>=20
> > +             (org-attach-use-annex)
> > +             (not (file-exists-p (file-symlink-p path))))
> > +        (call-process "git" nil nil nil "annex" "get" path))
>=20
> - Should this display a message before calling "git annex get" to let the
>   user know what's happening in case fetching the file takes some time?

That would make sense. I=E2=80=99ll change it.

> - Should there be a setting the controls whether attachments are
>   automatically fetched?

I don=E2=80=99t see why. If a file is managed in git annex and the user is =
trying to
open it, I can=E2=80=99t imagine why they wouldn=E2=80=99t want it fetched.

best, Erik
--
Sent from my free software system <http://fsf.org/>.